All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Mohammed Anees <pvmohammedanees2003@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, jmoyer@redhat.com, bcrl@kvack.org,
	jack@suse.cz, viro@zeniv.linux.org.uk, willy@infradead.org
Subject: Re: [PATCH] fs:aio: Remove TODO comment suggesting hash or array usage in io_cancel()
Date: Tue, 12 Nov 2024 14:13:39 +0100	[thread overview]
Message-ID: <20241112-begierde-skepsis-34f013abaa1f@brauner> (raw)
In-Reply-To: <20241112113906.15825-1-pvmohammedanees2003@gmail.com>

On Tue, 12 Nov 2024 17:08:34 +0530, Mohammed Anees wrote:
> The comment suggests a hash or array approach to
> store the active requests. Currently it iterates
> through all the active requests and when found
> deletes the requested request, in the linked list.
> However io_cancel() isn’t a frequently used operation,
> and optimizing it wouldn’t bring a substantial benefit
> to real users and the increased complexity of maintaining
> a hashtable for this would be significant and will slow
> down other operation. Therefore remove this TODO
> to avoid people spending time improving this.
> 
> [...]

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs:aio: Remove TODO comment suggesting hash or array usage in io_cancel()
      https://git.kernel.org/vfs/vfs/c/27e4f4fa65c2

      parent reply	other threads:[~2024-11-12 13:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 11:38 [PATCH] fs:aio: Remove TODO comment suggesting hash or array usage in io_cancel() Mohammed Anees
2024-11-12 12:02 ` Jan Kara
2024-11-12 13:13 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112-begierde-skepsis-34f013abaa1f@brauner \
    --to=brauner@kernel.org \
    --cc=bcrl@kvack.org \
    --cc=jack@suse.cz \
    --cc=jmoyer@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pvmohammedanees2003@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.