From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,mgorman@techsingularity.net,labbott@redhat.com,liuq131@chinatelecom.cn,akpm@linux-foundation.org
Subject: + mm-compaction-fix-the-total_isolated-in-strict-mode.patch added to mm-unstable branch
Date: Mon, 11 Nov 2024 16:23:06 -0800 [thread overview]
Message-ID: <20241112002307.629DAC4CECF@smtp.kernel.org> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2401 bytes --]
The patch titled
Subject: mm/compaction: fix the total_isolated in strict mode
has been added to the -mm mm-unstable branch. Its filename is
mm-compaction-fix-the-total_isolated-in-strict-mode.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-compaction-fix-the-total_isolated-in-strict-mode.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Qiang Liu <liuq131@chinatelecom.cn>
Subject: mm/compaction: fix the total_isolated in strict mode
Date: Sat, 2 Nov 2024 20:16:21 +0000
If the last cycle reads bogus compound_order() and blockpfn > end_pfn
occurs, it is possible that total_isolated will be less than nr_scanned.
In this case, strict mode should return 0, but the “if (strict &&
blockpfn < end_pfn)” statement cannot recognize this situation
Link: https://lkml.kernel.org/r/20241102201621.95291-1-liuq131@chinatelecom.cn
Signed-off-by: Qiang Liu <liuq131@chinatelecom.cn>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/compaction.c~mm-compaction-fix-the-total_isolated-in-strict-mode
+++ a/mm/compaction.c
@@ -699,7 +699,7 @@ isolate_fail:
* pages requested were isolated. If there were any failures, 0 is
* returned and CMA will fail.
*/
- if (strict && blockpfn < end_pfn)
+ if (strict && (blockpfn < end_pfn || total_isolated != nr_scanned))
total_isolated = 0;
cc->total_free_scanned += nr_scanned;
_
Patches currently in -mm which might be from liuq131@chinatelecom.cn are
mm-compaction-fix-the-total_isolated-in-strict-mode.patch
reply other threads:[~2024-11-12 0:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112002307.629DAC4CECF@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=labbott@redhat.com \
--cc=liuq131@chinatelecom.cn \
--cc=mgorman@techsingularity.net \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.