From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Xiao Liang <shaw.leon@gmail.com>, Jiri Pirko <jiri@resnulli.us>,
donald.hunter@redhat.com
Subject: Re: [PATCH net-next v1 2/2] tools/net/ynl: add async notification handling
Date: Tue, 12 Nov 2024 07:14:39 -0800 [thread overview]
Message-ID: <20241112071439.5ade3b1d@kernel.org> (raw)
In-Reply-To: <m24j4cvmlp.fsf@gmail.com>
On Tue, 12 Nov 2024 09:16:02 +0000 Donald Hunter wrote:
> >> I don't follow; what are you suggesting I initialise endtime to when
> >> duration is 0 ?
> >
> > I was suggesting:
> >
> > def poll_nft([...], duration=0)
> >
> > endtime = time.time() + duration
>
> I want it to run forever if a duration is not provided, but here
> endtime == starttime so it would exit immediately.
>
> I thought the original approach was fairly pythonic - if duration is not
> specified (None) then there would be no endtime (None).
Ah, makes perfect sense in hindsight, I misread the code.
prev parent reply other threads:[~2024-11-12 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 12:38 [PATCH net-next v1 0/2] tools/net/ynl: rework async notification handling Donald Hunter
2024-11-08 12:38 ` [PATCH net-next v1 1/2] Revert "tools/net/ynl: improve async notification handling" Donald Hunter
2024-11-08 12:38 ` [PATCH net-next v1 2/2] tools/net/ynl: add async notification handling Donald Hunter
2024-11-09 21:40 ` Jakub Kicinski
2024-11-11 11:06 ` Donald Hunter
2024-11-11 18:03 ` Jakub Kicinski
2024-11-12 9:16 ` Donald Hunter
2024-11-12 15:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112071439.5ade3b1d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaw.leon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.