All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: linux-mm@kvack.org, maple-tree@lists.infradead.org,
	stable@vger.kernel.org, Hajime Tazaki <thehajime@gmail.com>
Subject: Re: [PATCH] nommu: pass NULL argument to vma_iter_prealloc()
Date: Tue, 12 Nov 2024 08:46:03 -0800	[thread overview]
Message-ID: <20241112084603.1c4e351fe21c9602422bf052@linux-foundation.org> (raw)
In-Reply-To: <uyvmziiho2gq2h2f2qwxob2ji7xztrkpxadhcso5lpdrplt24q@nyuqxxiww623>

On Tue, 12 Nov 2024 07:46:18 -0500 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:

> Andrew,
> 
> Just in case you didn't notice, this patch was reviewed on another list.
> 
> Thanks,
> Liam
> 
> * Hajime Tazaki <thehajime@gmail.com> [241108 17:29]:
> > When deleting a vma entry from a maple tree, it has to pass NULL to
> > vma_iter_prealloc() in order to calculate internal state of the tree,
> > but it passed a wrong argument.  As a result, nommu kernels crashed upon
> > accessing a vma iterator, such as acct_collect() reading the size of
> > vma entries after do_munmap().
> > 
> > This commit fixes this issue by passing a right argument to the
> > preallocation call.
> > 
> > Fixes: b5df09226450 ("mm: set up vma iterator for vma_iter_prealloc() calls")
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> > Signed-off-by: Hajime Tazaki <thehajime@gmail.com>

Yep, thanks, 247d720b2c5d in mm-hotfixes-stable.

      reply	other threads:[~2024-11-12 16:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 22:28 [PATCH] nommu: pass NULL argument to vma_iter_prealloc() Hajime Tazaki
2024-11-12 12:46 ` Liam R. Howlett
2024-11-12 16:46   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112084603.1c4e351fe21c9602422bf052@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=thehajime@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.