From: kernel test robot <lkp@intel.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [thomas-weissschuh:b4/amdgpu-drm_edid 6/7] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:101: warning: Function parameter or struct member 'drm_edid' not described in 'dm_helpers_parse_edid_caps'
Date: Tue, 12 Nov 2024 13:58:17 +0800 [thread overview]
Message-ID: <202411121358.6vjrPutL-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/thomas.weissschuh/linux.git b4/amdgpu-drm_edid
head: 36a70587d73d8051d59295ea31b5ad1fcaad7779
commit: d236a4b83a0730653d4b3448f1111c858158d9b8 [6/7] drm/amd/display: Switch dc_sink to struct drm_edid
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20241112/202411121358.6vjrPutL-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241112/202411121358.6vjrPutL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411121358.6vjrPutL-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:101: warning: Function parameter or struct member 'drm_edid' not described in 'dm_helpers_parse_edid_caps'
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:101: warning: Excess function parameter 'edid' description in 'dm_helpers_parse_edid_caps'
vim +101 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c
613a7956deb3b1 Aurabindo Pillai 2023-06-12 87
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 88 /**
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 89 * dm_helpers_parse_edid_caps() - Parse edid caps
4562236b3bc0a2 Harry Wentland 2017-09-12 90 *
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 91 * @link: current detected link
4562236b3bc0a2 Harry Wentland 2017-09-12 92 * @edid: [in] pointer to edid
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 93 * @edid_caps: [in] pointer to edid caps
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 94 *
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 95 * Return: void
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 96 */
4562236b3bc0a2 Harry Wentland 2017-09-12 97 enum dc_edid_status dm_helpers_parse_edid_caps(
3c021931023a30 Claudio Suarez 2021-10-17 98 struct dc_link *link,
d236a4b83a0730 Thomas Weißschuh 2024-06-15 99 const struct drm_edid *drm_edid,
4562236b3bc0a2 Harry Wentland 2017-09-12 100 struct dc_edid_caps *edid_caps)
4562236b3bc0a2 Harry Wentland 2017-09-12 @101 {
3c021931023a30 Claudio Suarez 2021-10-17 102 struct amdgpu_dm_connector *aconnector = link->priv;
3c021931023a30 Claudio Suarez 2021-10-17 103 struct drm_connector *connector = &aconnector->base;
d236a4b83a0730 Thomas Weißschuh 2024-06-15 104 const struct edid *edid_buf;
4562236b3bc0a2 Harry Wentland 2017-09-12 105 struct cea_sad *sads;
4562236b3bc0a2 Harry Wentland 2017-09-12 106 int sad_count = -1;
4562236b3bc0a2 Harry Wentland 2017-09-12 107 int sadb_count = -1;
4562236b3bc0a2 Harry Wentland 2017-09-12 108 int i = 0;
4562236b3bc0a2 Harry Wentland 2017-09-12 109 uint8_t *sadb = NULL;
4562236b3bc0a2 Harry Wentland 2017-09-12 110
4562236b3bc0a2 Harry Wentland 2017-09-12 111 enum dc_edid_status result = EDID_OK;
4562236b3bc0a2 Harry Wentland 2017-09-12 112
d236a4b83a0730 Thomas Weißschuh 2024-06-15 113 if (!edid_caps || !drm_edid)
4562236b3bc0a2 Harry Wentland 2017-09-12 114 return EDID_BAD_INPUT;
4562236b3bc0a2 Harry Wentland 2017-09-12 115
d236a4b83a0730 Thomas Weißschuh 2024-06-15 116 edid_buf = drm_edid_raw(drm_edid);
d236a4b83a0730 Thomas Weißschuh 2024-06-15 117
d236a4b83a0730 Thomas Weißschuh 2024-06-15 118 if (!drm_edid_valid(drm_edid))
4562236b3bc0a2 Harry Wentland 2017-09-12 119 result = EDID_BAD_CHECKSUM;
4562236b3bc0a2 Harry Wentland 2017-09-12 120
4562236b3bc0a2 Harry Wentland 2017-09-12 121 edid_caps->manufacturer_id = (uint16_t) edid_buf->mfg_id[0] |
4562236b3bc0a2 Harry Wentland 2017-09-12 122 ((uint16_t) edid_buf->mfg_id[1])<<8;
4562236b3bc0a2 Harry Wentland 2017-09-12 123 edid_caps->product_id = (uint16_t) edid_buf->prod_code[0] |
4562236b3bc0a2 Harry Wentland 2017-09-12 124 ((uint16_t) edid_buf->prod_code[1])<<8;
4562236b3bc0a2 Harry Wentland 2017-09-12 125 edid_caps->serial_number = edid_buf->serial;
4562236b3bc0a2 Harry Wentland 2017-09-12 126 edid_caps->manufacture_week = edid_buf->mfg_week;
4562236b3bc0a2 Harry Wentland 2017-09-12 127 edid_caps->manufacture_year = edid_buf->mfg_year;
4562236b3bc0a2 Harry Wentland 2017-09-12 128
0b7778f4a63a1e Claudio Suarez 2021-10-17 129 drm_edid_get_monitor_name(edid_buf,
0b7778f4a63a1e Claudio Suarez 2021-10-17 130 edid_caps->display_name,
0b7778f4a63a1e Claudio Suarez 2021-10-17 131 AUDIO_INFO_DISPLAY_NAME_SIZE_IN_CHARS);
4562236b3bc0a2 Harry Wentland 2017-09-12 132
3c021931023a30 Claudio Suarez 2021-10-17 133 edid_caps->edid_hdmi = connector->display_info.is_hdmi;
4562236b3bc0a2 Harry Wentland 2017-09-12 134
b7cdccc6a84956 Ryan Lin 2024-02-28 135 apply_edid_quirks(edid_buf, edid_caps);
b7cdccc6a84956 Ryan Lin 2024-02-28 136
d236a4b83a0730 Thomas Weißschuh 2024-06-15 137 sad_count = drm_edid_to_sad(edid_buf, &sads);
ae2a3495973ef0 Jean Delvare 2019-09-04 138 if (sad_count <= 0)
4562236b3bc0a2 Harry Wentland 2017-09-12 139 return result;
4562236b3bc0a2 Harry Wentland 2017-09-12 140
1347b15d5e8e16 Srinivasan Shanmugam 2023-08-13 141 edid_caps->audio_mode_count = min(sad_count, DC_MAX_AUDIO_DESC_COUNT);
4562236b3bc0a2 Harry Wentland 2017-09-12 142 for (i = 0; i < edid_caps->audio_mode_count; ++i) {
4562236b3bc0a2 Harry Wentland 2017-09-12 143 struct cea_sad *sad = &sads[i];
4562236b3bc0a2 Harry Wentland 2017-09-12 144
4562236b3bc0a2 Harry Wentland 2017-09-12 145 edid_caps->audio_modes[i].format_code = sad->format;
731a373698c967 Harry Wentland 2018-03-07 146 edid_caps->audio_modes[i].channel_count = sad->channels + 1;
4562236b3bc0a2 Harry Wentland 2017-09-12 147 edid_caps->audio_modes[i].sample_rate = sad->freq;
4562236b3bc0a2 Harry Wentland 2017-09-12 148 edid_caps->audio_modes[i].sample_size = sad->byte2;
4562236b3bc0a2 Harry Wentland 2017-09-12 149 }
4562236b3bc0a2 Harry Wentland 2017-09-12 150
d236a4b83a0730 Thomas Weißschuh 2024-06-15 151 sadb_count = drm_edid_to_speaker_allocation(edid_buf, &sadb);
4562236b3bc0a2 Harry Wentland 2017-09-12 152
4562236b3bc0a2 Harry Wentland 2017-09-12 153 if (sadb_count < 0) {
4562236b3bc0a2 Harry Wentland 2017-09-12 154 DRM_ERROR("Couldn't read Speaker Allocation Data Block: %d\n", sadb_count);
4562236b3bc0a2 Harry Wentland 2017-09-12 155 sadb_count = 0;
4562236b3bc0a2 Harry Wentland 2017-09-12 156 }
4562236b3bc0a2 Harry Wentland 2017-09-12 157
4562236b3bc0a2 Harry Wentland 2017-09-12 158 if (sadb_count)
4562236b3bc0a2 Harry Wentland 2017-09-12 159 edid_caps->speaker_flags = sadb[0];
4562236b3bc0a2 Harry Wentland 2017-09-12 160 else
4562236b3bc0a2 Harry Wentland 2017-09-12 161 edid_caps->speaker_flags = DEFAULT_SPEAKER_LOCATION;
4562236b3bc0a2 Harry Wentland 2017-09-12 162
4562236b3bc0a2 Harry Wentland 2017-09-12 163 kfree(sads);
4562236b3bc0a2 Harry Wentland 2017-09-12 164 kfree(sadb);
4562236b3bc0a2 Harry Wentland 2017-09-12 165
4562236b3bc0a2 Harry Wentland 2017-09-12 166 return result;
4562236b3bc0a2 Harry Wentland 2017-09-12 167 }
4562236b3bc0a2 Harry Wentland 2017-09-12 168
:::::: The code at line 101 was first introduced by commit
:::::: 4562236b3bc0a28aeb6ee93b2d8a849a4c4e1c7c drm/amd/dc: Add dc display driver (v2)
:::::: TO: Harry Wentland <harry.wentland@amd.com>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-11-12 5:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411121358.6vjrPutL-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux@weissschuh.net \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.