From: Rob Herring <robh@kernel.org>
To: Philipp Rosenberger <p.rosenberger@kunbus.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
"Lino Sanfilippo" <l.sanfilippo@kunbus.com>,
"Thomas Böhler" <t.boehler@kunbus.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v3 2/2] rtc: pcf2127: Add 'nxp,battery-switchover' DT property to enable battery switch-over
Date: Tue, 12 Nov 2024 10:38:40 -0600 [thread overview]
Message-ID: <20241112163840.GA1151895-robh@kernel.org> (raw)
In-Reply-To: <20241111154144.163604-3-p.rosenberger@kunbus.com>
On Mon, Nov 11, 2024 at 04:41:44PM +0100, Philipp Rosenberger wrote:
> The PCF2127, PCF2129, and PCA2129 RTCs have the battery switch-over function
> enabled by default. However, the newer PCF2131 RTC has the opposite default
> behavior, requiring explicit enablement for battery backup.
Subject is wrong.
>
> Add support for the `nxp,battery-backed` device tree property to enable battery
> switch-over in standard mode for the rtc-pcf2127 driver. If this property is set
> and no battery switch-over mode is already configured, the driver will enable
> standard mode; otherwise, existing configurations remain unchanged.
>
> Signed-off-by: Philipp Rosenberger <p.rosenberger@kunbus.com>
> ---
> drivers/rtc/rtc-pcf2127.c | 76 +++++++++++++++++++++++++++++++--------
> 1 file changed, 61 insertions(+), 15 deletions(-)
next prev parent reply other threads:[~2024-11-12 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 15:41 [PATCH v3 0/2] rtc: pcf2127: make battery switch-over configurable Philipp Rosenberger
2024-11-11 15:41 ` [PATCH v3 1/2] dt-bindings: rtc: pcf2127: Add nxp,battery-backed flag Philipp Rosenberger
2024-11-12 16:40 ` Rob Herring
2024-11-11 15:41 ` [PATCH v3 2/2] rtc: pcf2127: Add 'nxp,battery-switchover' DT property to enable battery switch-over Philipp Rosenberger
2024-11-11 18:27 ` Christophe JAILLET
2024-11-12 16:38 ` Rob Herring [this message]
2024-11-14 8:51 ` [PATCH v3 0/2] rtc: pcf2127: make battery switch-over configurable Alexandre Belloni
2024-11-27 12:58 ` Philipp Rosenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112163840.GA1151895-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hvilleneuve@dimonoff.com \
--cc=krzk+dt@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=p.rosenberger@kunbus.com \
--cc=t.boehler@kunbus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.