Re: [PATCH net-next v2 2/2] tools/net/ynl: add async notification handling

[Jakub Kicinski <kuba@kernel.org>]

some comments for your consideration, if you prefer to keep as is:

Acked-by: Jakub Kicinski <kuba@kernel.org>

On Tue, 12 Nov 2024 11:17:27 +0000 Donald Hunter wrote:
> +    def poll_ntf(self, duration=None):
> +        endtime = time.time() + duration if duration is not None else None

we can record starttime here, and avoid the complex logic..

> +        selector = selectors.DefaultSelector()
> +        selector.register(self.sock, selectors.EVENT_READ)
> +
> +        while True:
> +            try:
> +                yield self.async_msg_queue.get_nowait()
> +            except queue.Empty:
> +                if endtime is not None:
> +                    interval = endtime - time.time()

then here:

		if duration is not None:
			timeout = time.time() - starttime + duration

and rest as is (modulo the s/interval/timeout/)

> +                    if interval <= 0:
> +                        return
> +                else:
> +                    interval = None
> +                events = selector.select(interval)
> +                if events:
> +                    self.check_ntf()