All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gediminas Repecka <gediminas.repecka@gmail.com>
Cc: jasowang@redhat.com, virtualization@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vdpa: vdpa_sim: vdpa_sim_net: fixed cofing style issues
Date: Tue, 12 Nov 2024 18:07:00 -0500	[thread overview]
Message-ID: <20241112180522-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20241107191941.37300-1-gediminas.repecka@gmail.com>


On Thu, Nov 07, 2024 at 09:19:41PM +0200, Gediminas Repecka wrote:
> Fixed coding style issues reported by checkpatch script
> ---

A lot is wrong with this submission, given it's supposed to fix
checkpatch:

- no signature
- typo in subject
- not using direct voice (Fix, not Fixed)


pls fix and resubmit

>  drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> index 6caf09a1907b..0705aff74cf3 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> @@ -53,7 +53,7 @@ struct vdpasim_cq_stats {
>  	u64 errors;
>  };
> 
> -struct vdpasim_net{
> +struct vdpasim_net {
>  	struct vdpasim vdpasim;
>  	struct vdpasim_dataq_stats tx_stats;
>  	struct vdpasim_dataq_stats rx_stats;
> @@ -293,7 +293,7 @@ static int vdpasim_net_get_stats(struct vdpasim *vdpasim, u16 idx,
>  	unsigned int start;
>  	int err = -EMSGSIZE;
> 
> -	switch(idx) {
> +	switch (idx) {
>  	case 0:
>  		do {
>  			start = u64_stats_fetch_begin(&net->rx_stats.syncp);
> @@ -543,7 +543,7 @@ static struct vdpa_mgmt_dev mgmt_dev = {
>  	.ops = &vdpasim_net_mgmtdev_ops,
>  	.config_attr_mask = (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR |
>  			     1 << VDPA_ATTR_DEV_NET_CFG_MTU |
> -		             1 << VDPA_ATTR_DEV_FEATURES),
> +			     1 << VDPA_ATTR_DEV_FEATURES),
>  	.max_supported_vqs = VDPASIM_NET_VQ_NUM,
>  	.supported_features = VDPASIM_NET_FEATURES,
>  };
> 
> 2.34.1


      reply	other threads:[~2024-11-12 23:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 19:19 [PATCH] vdpa: vdpa_sim: vdpa_sim_net: fixed cofing style issues Gediminas Repecka
2024-11-12 23:07 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112180522-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=gediminas.repecka@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.