Re: [PATCH v7 2/2] pwm: add support for NXPs high-side switch MC33XS2410

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241109174135.26292-3-dima.fedrau@gmail.com>
References: <20241109174135.26292-3-dima.fedrau@gmail.com>
TO: Dimitri Fedrau <dima.fedrau@gmail.com>
CC: Dimitri Fedrau <dima.fedrau@gmail.com>
CC: "Uwe Kleine-König" <ukleinek@kernel.org>
CC: Rob Herring <robh+dt@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: linux-pwm@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org

Hi Dimitri,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.12-rc7 next-20241112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dimitri-Fedrau/dt-bindings-pwm-add-support-for-MC33XS2410/20241110-014336
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20241109174135.26292-3-dima.fedrau%40gmail.com
patch subject: [PATCH v7 2/2] pwm: add support for NXPs high-side switch MC33XS2410
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: s390-randconfig-r073-20241112 (https://download.01.org/0day-ci/archive/20241113/202411131646.RTVxOlpg-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202411131646.RTVxOlpg-lkp@intel.com/

smatch warnings:
drivers/pwm/pwm-mc33xs2410.c:184 mc33xs2410_pwm_get_freq() error: uninitialized symbol 'step'.

vim +/step +184 drivers/pwm/pwm-mc33xs2410.c

23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  152  
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  153  static u8 mc33xs2410_pwm_get_freq(u64 period)
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  154  {
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  155  	u8 step, count;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  156  
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  157  	/*
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  158  	 * Check which step is appropriate for the given period, starting with
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  159  	 * the highest frequency(lowest period). Higher frequencies are
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  160  	 * represented with better resolution by the device. Therefore favor
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  161  	 * frequency range with the better resolution to minimize error
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  162  	 * introduced by the frequency steps.
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  163  	 */
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  164  
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  165  	switch (period) {
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  166  	case MC33XS2410_PWM_MIN_PERIOD ... MC33XS2410_PWM_MAX_PERIOD(3):
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  167  		step = 3;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  168  		break;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  169  	case MC33XS2410_PWM_MAX_PERIOD(3) + 1 ... MC33XS2410_PWM_MAX_PERIOD(2):
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  170  		step = 2;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  171  		break;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  172  	case MC33XS2410_PWM_MAX_PERIOD(2) + 1 ... MC33XS2410_PWM_MAX_PERIOD(1):
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  173  		step = 1;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  174  		break;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  175  	case MC33XS2410_PWM_MAX_PERIOD(1) + 1 ... MC33XS2410_PWM_MAX_PERIOD(0):
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  176  		step = 0;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  177  		break;
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  178  	}
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  179  
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  180  	/*
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  181  	 * Round up here because a higher count results in a higher frequency
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  182  	 * and so a smaller period.
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  183  	 */
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09 @184  	count = DIV_ROUND_UP((u32)MC33XS2410_PWM_MAX_PERIOD(step), (u32)period);
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  185  	return FIELD_PREP(MC33XS2410_PWM_FREQ_STEP, step) |
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  186  	       FIELD_PREP(MC33XS2410_PWM_FREQ_COUNT, count - 1);
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  187  }
23a0a66c9fc5eb0 Dimitri Fedrau 2024-11-09  188  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki