From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F41502E634; Thu, 14 Nov 2024 03:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731553762; cv=none; b=D7MQjxAuhLqvwKFMUVZIrMVKqsVohhJTmWCPwuEK7GBIL0pWsNw7G0ikGcdBUZKStgZehtD4doAA2z7y/lVDobRq5OZC4NtsHiaPPAz+rK5hpx2mr0LiSHkTROvYVYOCEo3xOmMQdrGItkf26LsEUE00UHA8mmW0eqOQ/NMSw5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731553762; c=relaxed/simple; bh=aNA+MUiXR33lNnb7g+eD9z36PEo+w4KP8BYPgK0Kh2w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=osPInc96nhDVcaJX6N+MCuC2VQDvZ9ImQiwLIDSBBkgBqrYstwdMY82GvChGhctlgZeADcaAjnGPqQH+y0lLsc5ancLFtamJQFHRi0xvWsy+5ENEZqy1JO7TGqRixgPYpEXc676+Ay9dW3m5QYovAbeIsOe/Xbnz0GF/RBs4E3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QQG4UBxZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QQG4UBxZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68434C4CEC3; Thu, 14 Nov 2024 03:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731553761; bh=aNA+MUiXR33lNnb7g+eD9z36PEo+w4KP8BYPgK0Kh2w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QQG4UBxZzz99WLCh1CqhlhsxLgYpBVK2nXRK8PkrOJ1mtquva9FvsnXw1+Pvo1u01 kSoXoKQiAyD+nsX0Os/T+IldoBGTutZN8QeYsOQWACKR6kiENdOaRl3yjSfmZmlm9s KNF+MSBp2oCkJb7cdVy0+vI5buypTfdDmifDPRCy6Y9M4YNvY85ZFan3GIn3blCBYD JAOlzbq1vawb+i3Qh6SodcO1n6xxgKj/n+Sl2mHyiQiISKC3JZRFeoWFG+/Ag4w1yb qwmxitYYnkKiAe0EJaElkWrY0I1Jciy5ki/Zjhmxi2d3//xSeBERMYfmaHdbEsU8P5 9MR0sqfovkxlQ== Date: Wed, 13 Nov 2024 19:09:20 -0800 From: Jakub Kicinski To: Jian Zhang Cc: netdev@vger.kernel.org, openbmc@lists.ozlabs.org, Jeremy Kerr , Matt Johnston , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next] mctp i2c: notify user space on TX failure Message-ID: <20241113190920.0ceaddf2@kernel.org> In-Reply-To: <20241108094206.2808293-1-zhangjian.3032@bytedance.com> References: <20241108094206.2808293-1-zhangjian.3032@bytedance.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 Nov 2024 17:42:06 +0800 Jian Zhang wrote: > diff --git a/drivers/net/mctp/mctp-i2c.c b/drivers/net/mctp/mctp-i2c.c > index 4dc057c121f5..e9a835606dfc 100644 > --- a/drivers/net/mctp/mctp-i2c.c > +++ b/drivers/net/mctp/mctp-i2c.c > @@ -485,6 +485,7 @@ static void mctp_i2c_xmit(struct mctp_i2c_dev *midev, struct sk_buff *skb) > struct mctp_i2c_hdr *hdr; > struct i2c_msg msg = {0}; > u8 *pecp; > + struct sock *sk; > int rc; > nit: order the variable declaration lines longest to shortest > @@ -551,6 +552,14 @@ static void mctp_i2c_xmit(struct mctp_i2c_dev *midev, struct sk_buff *skb) > dev_warn_ratelimited(&midev->adapter->dev, > "__i2c_transfer failed %d\n", rc); > stats->tx_errors++; > + > + sk = skb->sk; > + if (sk) { > + sk->sk_err = -rc; > + if (!sock_flag(sk, SOCK_DEAD)) > + sk_error_report(sk); > + } notifying socket in the xmit handler of a netdev is a bit strange, could you do it somewhere higher in the MCTP stack? -- pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1D1CD637DA for ; Thu, 14 Nov 2024 03:09:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XplW017M4z3cLY for ; Thu, 14 Nov 2024 14:09:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:4641:c500::1" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731553767; cv=none; b=JGiuz9kjRpT8273LN90qQm2x8U8A5DRGFd3UDW1xtb0tz7bv8gtS6copk4ksCVdXNNQGd7MNC9AaEbx+ZAtGJ29dpJepUJaRFbEmMQLdcfE21eaE0XJuGkdNUXuBi0Tqjf8hHuxeRk6JfU35dSFEb6ZiURJpLOn9BXqi2EkdlVrRclw/0ieiLDfu0Xw1oALFmr64csRpS4Wt97u4uKyQDb4MmervhcM6juHC+I/yZxs4iRbTBvbku/Rf77zhOdY5PSn0v8lSgJ0YQC3BbwEFXP+ucmf3G0xaMhx5L6MXeJNZy2IJNJxv7YkbtrvSFQQSvFYzR4uHx9+oGPAO5wzMiQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731553767; c=relaxed/relaxed; bh=Jp6q/hzaronqL1OOIiSDXonIRum5UBHnh9k/VcRsoPg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SeJjKSi8RopttGpr3Utj76R8xSAWdnycJ+jNRcK7DK0PxnEICe6PH92hZZ23H/8JwiI0k7e0usjNgoSJZkBRBFzk66V7ozX4nncs3acmSCck47Lm0v8oUFTTbBUkQ33R8Zy1WAQbJdYvI2IU+W3h8CDkPMA/G0dTJCKb2iggTngeiBDA65yL8sYYEckQ76G50ovTmLvyKhQ5bij7RlcK0Q9Jv/iG16I19j080HlUQvkwodf0n2J/syH7RMe4t1RtNoHwOTkOhLRoMppk30DPcoFcISHBXVCI1cu7oLzI3K0jFsXgrydCkbr23PpPLOEvTQ9iBOdvrNOf/U3agspKlQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QQG4UBxZ; dkim-atps=neutral; spf=pass (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QQG4UBxZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XplVt0qddz2yMv for ; Thu, 14 Nov 2024 14:09:26 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D0A265C5808; Thu, 14 Nov 2024 03:08:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68434C4CEC3; Thu, 14 Nov 2024 03:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731553761; bh=aNA+MUiXR33lNnb7g+eD9z36PEo+w4KP8BYPgK0Kh2w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QQG4UBxZzz99WLCh1CqhlhsxLgYpBVK2nXRK8PkrOJ1mtquva9FvsnXw1+Pvo1u01 kSoXoKQiAyD+nsX0Os/T+IldoBGTutZN8QeYsOQWACKR6kiENdOaRl3yjSfmZmlm9s KNF+MSBp2oCkJb7cdVy0+vI5buypTfdDmifDPRCy6Y9M4YNvY85ZFan3GIn3blCBYD JAOlzbq1vawb+i3Qh6SodcO1n6xxgKj/n+Sl2mHyiQiISKC3JZRFeoWFG+/Ag4w1yb qwmxitYYnkKiAe0EJaElkWrY0I1Jciy5ki/Zjhmxi2d3//xSeBERMYfmaHdbEsU8P5 9MR0sqfovkxlQ== Date: Wed, 13 Nov 2024 19:09:20 -0800 From: Jakub Kicinski To: Jian Zhang Subject: Re: [PATCH net-next] mctp i2c: notify user space on TX failure Message-ID: <20241113190920.0ceaddf2@kernel.org> In-Reply-To: <20241108094206.2808293-1-zhangjian.3032@bytedance.com> References: <20241108094206.2808293-1-zhangjian.3032@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, openbmc@lists.ozlabs.org, open list , Eric Dumazet , Jeremy Kerr , Matt Johnston , Paolo Abeni , "David S. Miller" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, 8 Nov 2024 17:42:06 +0800 Jian Zhang wrote: > diff --git a/drivers/net/mctp/mctp-i2c.c b/drivers/net/mctp/mctp-i2c.c > index 4dc057c121f5..e9a835606dfc 100644 > --- a/drivers/net/mctp/mctp-i2c.c > +++ b/drivers/net/mctp/mctp-i2c.c > @@ -485,6 +485,7 @@ static void mctp_i2c_xmit(struct mctp_i2c_dev *midev, struct sk_buff *skb) > struct mctp_i2c_hdr *hdr; > struct i2c_msg msg = {0}; > u8 *pecp; > + struct sock *sk; > int rc; > nit: order the variable declaration lines longest to shortest > @@ -551,6 +552,14 @@ static void mctp_i2c_xmit(struct mctp_i2c_dev *midev, struct sk_buff *skb) > dev_warn_ratelimited(&midev->adapter->dev, > "__i2c_transfer failed %d\n", rc); > stats->tx_errors++; > + > + sk = skb->sk; > + if (sk) { > + sk->sk_err = -rc; > + if (!sock_flag(sk, SOCK_DEAD)) > + sk_error_report(sk); > + } notifying socket in the xmit handler of a netdev is a bit strange, could you do it somewhere higher in the MCTP stack? -- pw-bot: cr