From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00C156AAD; Thu, 14 Nov 2024 03:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731554351; cv=none; b=XBXR/5CLF8Q6/YqNvONqXd8kOG8yRpnoUKnerlpPzHqyRr1pc91UbQwbMF/dKyWDWdHUjGtfC/WH5vKY+2Z9xboM1aNfaU1INTvoKm2fMzRbOAhzsj/u1yVWbtMw9zuWG3i6enE+2GrDfBEqXk036iWHbVkdFwYlQxwLMvYkaLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731554351; c=relaxed/simple; bh=Yq1+6nK+LxMRxpgCo00ZoaEvjLTfqSrkJRDCOrj8YJk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hoe7zaOgcmyCGVtmy6UNEjOEcXEBWhpJt2SLScoXHb6tFKFAO9LBLSo4ppEOrx+2aHuPr+fX8YrQBZ7yhd9WKYQmy17qoDbECZPEgZDQa+twIQOjpRpxiCJvZVPRXoy8JlS1WEQjW66f+8jnvT5lUtnbx4xIVd/w+b3MUEl2J78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MYTYmt0Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MYTYmt0Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37128C4CEC3; Thu, 14 Nov 2024 03:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731554350; bh=Yq1+6nK+LxMRxpgCo00ZoaEvjLTfqSrkJRDCOrj8YJk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MYTYmt0Zeb+GLahunFyo7ba2qGhn6Ao2p7cOMvd3FG6jwMdUrE9Lsmk0syPpvRaSM A6UkDKgAg1u+/zP/+mbanWyOlaTn8ZDaLMcfS8+z97s4nGMsbDxq2DtllrRWTK58Qu ZVA13UA6XjH1ObJdhzfXAbHhvoaP87AEfNyfHsUnbjXr0YD6Sr2XOf5cbTJYxJXEoI 9/A3ZFn0lXzV2eOods0xFCEjLVxh9tYo6XpkTWS/si+GwNfV54MIqBUIIvBeiw7HPD qHXLxNVgPW9LVgl2HXUh45wa54m0SwmyvIU+DMOnDb+vke2YdQ2cCSuZuPN4ewRZ1J DGZ3G3Pl5ErQw== Date: Wed, 13 Nov 2024 19:19:09 -0800 From: Jakub Kicinski To: Jeremy Kerr Cc: Jian Zhang , netdev@vger.kernel.org, openbmc@lists.ozlabs.org, Matt Johnston , "David S. Miller" , Eric Dumazet , Paolo Abeni , open list Subject: Re: [PATCH net-next] mctp i2c: notify user space on TX failure Message-ID: <20241113191909.10cf495e@kernel.org> In-Reply-To: References: <20241108094206.2808293-1-zhangjian.3032@bytedance.com> <20241113190920.0ceaddf2@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 14 Nov 2024 11:13:33 +0800 Jeremy Kerr wrote: > > notifying socket in the xmit handler of a netdev is a bit strange, > > could you do it somewhere higher in the MCTP stack? > > Sounds like that would be useful in general for MCTP, but we don't have > a facility for that at present. Any existing implementation you would > suggest modelling this on? routing isn't really my forte, TBH, what eats the error so that it doesn't come out of mctp_local_output() ? Do you use qdiscs on top of the MCTP devices? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 080CED637DB for ; Thu, 14 Nov 2024 03:19:29 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XplkF3GWJz3cTh for ; Thu, 14 Nov 2024 14:19:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:4641:c500::1" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731554353; cv=none; b=YaVKXH4Rrpf1lFMvmMpDhAeYkJcYpv8Pp6knt7gmigvhI9lcN3M799KjUxtdjVjEkO3WjehhhcrFNDMS8iCEJMqitCwf6HjHhSzE2XEXF3ZZ0aAEH42rtbSwl9dOm+M8BVzwaakOpIfPkA90Rk09CseSJwQCeJtH8KsM6IOhroyVVqW92WGpA/2Sn4TYazojcsqb3L1Lys4AMfE6gFLsUMkM4fYMxctCILjwm4KsWrf1pSdKivtCIR6RNzncITUr1Ux9Q0M3RZP75MWKgUOp1GkOS2WKW+dlZaLKXf+3aRwDCSWtWLtx0bbQxxbbXEFCl9IgU9lsEp2s076Szp5hvw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731554353; c=relaxed/relaxed; bh=Urs/DcUApj0uGKM9NeJDRz7l+4sgH4wqrxLw+oSORAw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oSNasSa9gb7N0guzHS3Carqx6nM79DTAtqjcYBbPJe8GswEUt/5vwwK35GlhBBsfYRh1sMkO+X/qSrA6Xhzde35ndrzsa3FOL5QGfXYJGY5vkNsW81eUsB53AtjVAmyk5bHVXe/FK58Ava0UDvirDK/R3VditXTC1YNMHvbKVvO8WzJDSeGJC28qAsQ0mUlgx0y9hNPBplsJiXla3TzmZZoVjydJs3doYBuY0Wp40oUDR63l5iqBt3I/zXkp70hXmEt3TsrFwXG3kf9EBM75qZ2uz4yMs2Qnap1t+iQESZr20WNVsTAkovxhfTOJBJMOTb/S4D3UDdD/rsrGCHtoIw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=MYTYmt0Z; dkim-atps=neutral; spf=pass (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=MYTYmt0Z; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Xplk84xb2z2yXm for ; Thu, 14 Nov 2024 14:19:12 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A22D15C5C0F; Thu, 14 Nov 2024 03:18:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37128C4CEC3; Thu, 14 Nov 2024 03:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731554350; bh=Yq1+6nK+LxMRxpgCo00ZoaEvjLTfqSrkJRDCOrj8YJk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MYTYmt0Zeb+GLahunFyo7ba2qGhn6Ao2p7cOMvd3FG6jwMdUrE9Lsmk0syPpvRaSM A6UkDKgAg1u+/zP/+mbanWyOlaTn8ZDaLMcfS8+z97s4nGMsbDxq2DtllrRWTK58Qu ZVA13UA6XjH1ObJdhzfXAbHhvoaP87AEfNyfHsUnbjXr0YD6Sr2XOf5cbTJYxJXEoI 9/A3ZFn0lXzV2eOods0xFCEjLVxh9tYo6XpkTWS/si+GwNfV54MIqBUIIvBeiw7HPD qHXLxNVgPW9LVgl2HXUh45wa54m0SwmyvIU+DMOnDb+vke2YdQ2cCSuZuPN4ewRZ1J DGZ3G3Pl5ErQw== Date: Wed, 13 Nov 2024 19:19:09 -0800 From: Jakub Kicinski To: Jeremy Kerr Subject: Re: [PATCH net-next] mctp i2c: notify user space on TX failure Message-ID: <20241113191909.10cf495e@kernel.org> In-Reply-To: References: <20241108094206.2808293-1-zhangjian.3032@bytedance.com> <20241113190920.0ceaddf2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, openbmc@lists.ozlabs.org, Eric Dumazet , open list , Jian Zhang , Matt Johnston , Paolo Abeni , "David S. Miller" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, 14 Nov 2024 11:13:33 +0800 Jeremy Kerr wrote: > > notifying socket in the xmit handler of a netdev is a bit strange, > > could you do it somewhere higher in the MCTP stack? > > Sounds like that would be useful in general for MCTP, but we don't have > a facility for that at present. Any existing implementation you would > suggest modelling this on? routing isn't really my forte, TBH, what eats the error so that it doesn't come out of mctp_local_output() ? Do you use qdiscs on top of the MCTP devices?