From: Joel Fernandes <joel@joelfernandes.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC 3/3] tick-sched: Replace jiffie readout with idle_entrytime
Date: Wed, 13 Nov 2024 21:46:03 +0000 [thread overview]
Message-ID: <20241113214603.GB2331600@google.com> (raw)
In-Reply-To: <87y11omrsk.ffs@tglx>
On Tue, Nov 12, 2024 at 03:48:43PM +0100, Thomas Gleixner wrote:
> On Sun, Nov 10 2024 at 22:55, Joel Fernandes wrote:
> >
> > + /*
> > + * There is some time that passes between when clocksource starts and the
> > + * first time tick device is setup. Offset basejiff by that.
> > + */
> > + basejiff -= DIV_ROUND_DOWN_ULL(tick_first_period, TICK_NSEC);
>
> We clearly need yet another division here. Especially as that division
> results in the exactly same value every time.
Yeah I fixed it in my v2 but did not post it yet:
https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/commit/?h=timers/tick-sched&id=60707e27418e3bca026be0bd9b1eacfe2a6ce72a
I will hold back on posting till we finish discussing on this RFC.
thanks,
- Joel
next prev parent reply other threads:[~2024-11-13 21:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 17:48 [RFC 0/3] tick-sched cleanups Joel Fernandes (Google)
2024-11-08 17:48 ` [RFC 1/3] tick-sched: Remove last_tick and calculate next tick from now Joel Fernandes (Google)
2024-11-11 23:43 ` Frederic Weisbecker
2024-11-12 13:46 ` Thomas Gleixner
2024-11-12 13:56 ` Frederic Weisbecker
2024-11-12 18:20 ` Joel Fernandes
2024-11-12 18:33 ` Joel Fernandes
2024-11-13 12:40 ` Frederic Weisbecker
2024-11-13 21:40 ` Joel Fernandes
2024-11-08 17:48 ` [RFC 2/3] tick-sched: Keep tick on if hrtimer is due imminently Joel Fernandes (Google)
2024-11-11 12:37 ` Christian Loehle
2024-11-11 15:56 ` Joel Fernandes
2024-11-11 16:55 ` Christian Loehle
2024-11-11 17:17 ` Joel Fernandes
2024-11-08 17:48 ` [RFC 3/3] tick-sched: Replace jiffie readout with idle_entrytime Joel Fernandes (Google)
2024-11-10 22:55 ` Joel Fernandes
2024-11-12 14:48 ` Thomas Gleixner
2024-11-13 21:46 ` Joel Fernandes [this message]
2024-11-11 22:25 ` Frederic Weisbecker
2024-11-13 22:39 ` Joel Fernandes
2024-11-12 14:30 ` Thomas Gleixner
2024-11-13 22:18 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113214603.GB2331600@google.com \
--to=joel@joelfernandes.org \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.