From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3F47175D20;
	Wed, 13 Nov 2024 06:06:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1731477962; cv=none; b=mDwpk3HCh2vTBTWRS7oXLNXKJ33ttyi5dAfvKb6mV/w83yn3PSY9yf+cZJNEJOEEx5hEyp1R1SlQGvmXyPCCYTBJ9i4ZEpR/+c6i+0Ol25y1lVGJ8dbPc6XOOevVs4cGlQ0EQvmXB1uUDuL5h/OtGLObQCy5x8yuDR5OhSfNcpM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1731477962; c=relaxed/simple;
	bh=yaQum6PGgtZHU8rbzjpl4yQ8Vdgc6rT+xrm0zMXBfHQ=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=cHRdW/n6jRWAsdJQjZSP2jvLqD4pQ+O8iZXzhE6/uzNncfc4xojc6g7rGRrQNgw+KBve8riRB+pEff/+dUC7xexlW6ufqq6h518JflVsFhSv/S6QgglkCqLc7rzlkvjPdcndaFCT5knnRYAs/ZwKTBad7KBTxzCdRiXMBzoxtmI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=P/VzbwCL; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="P/VzbwCL"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF843C4CECD;
	Wed, 13 Nov 2024 06:06:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1731477962;
	bh=yaQum6PGgtZHU8rbzjpl4yQ8Vdgc6rT+xrm0zMXBfHQ=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=P/VzbwCLAPJ0huVfDamujqDIGr7n4Ah4eLBhoN6ZPbtzaJGlrSwiTuB7Ud96ghMR6
	 m3OoplGxK9bmcmRsezqyHZdpmwLX4CGkQwbCMa6lTIFNfTXW1neKlNpL0IEbnl3o2H
	 itfs8lnSAU8+KN6VlZHv7bgJ1hiUpI7NzK4WwBkk=
Date: Wed, 13 Nov 2024 07:05:59 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: "Rangoju, Raju" <raju.rangoju@amd.com>
Cc: linux-usb@vger.kernel.org, mathias.nyman@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: xhci: quirk for data loss in ISOC transfers
Message-ID: <2024111330-crusher-alike-a88d@gregkh>
References: <20241112122104.120633-1-Raju.Rangoju@amd.com>
 <2024111226-spender-saturate-dc6e@gregkh>
 <2a02f0c3-f535-4ac0-d29f-a33e0c45cf4c@amd.com>
Precedence: bulk
X-Mailing-List: linux-usb@vger.kernel.org
List-Id: <linux-usb.vger.kernel.org>
List-Subscribe: <mailto:linux-usb+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-usb+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2a02f0c3-f535-4ac0-d29f-a33e0c45cf4c@amd.com>

On Tue, Nov 12, 2024 at 07:02:40PM +0530, Rangoju, Raju wrote:
> 
> 
> On 11/12/2024 5:54 PM, Greg KH wrote:
> > On Tue, Nov 12, 2024 at 05:51:04PM +0530, Raju Rangoju wrote:
> > > During the High-Speed Isochronous Audio transfers, xHCI
> > > controller on certain AMD platforms experiences momentary data
> > > loss. This results in Missed Service Errors (MSE) being
> > > generated by the xHCI.
> > > 
> > > The root cause of the MSE is attributed to the ISOC OUT endpoint
> > > being omitted from scheduling. This can happen either when an IN
> > > endpoint with a 64ms service interval is pre-scheduled prior to
> > > the ISOC OUT endpoint or when the interval of the ISOC OUT
> > > endpoint is shorter than that of the IN endpoint. Consequently,
> > > the OUT service is neglected when an IN endpoint with a service
> > > interval exceeding 32ms is scheduled concurrently (every 64ms in
> > > this scenario).
> > > 
> > > This issue is particularly seen on certain older AMD platforms.
> > > To mitigate this problem, it is recommended to adjust the service
> > > interval of the IN endpoint to not exceed 32ms (interval 8). This
> > > adjustment ensures that the OUT endpoint will not be bypassed,
> > > even if a smaller interval value is utilized.
> > > 
> > > Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
> > 
> > You don't want this backported to any older kernels?  Why not?
> 
> Hi Greg, Yes, backporting is needed, but some of products were released back
> in 2018, not sure of the exact commit id to quote here for backporting as
> there were no precise commits that added this initial support in the first
> place.
> 
> Would you mind tagging it to all stable kernels. Let me know if the patch
> needs to be respinned.

Yes, please resend it with the proper tag, don't ask maintainers to
hand-edit changes for you, that does not scale at all.

thanks,

greg k-h