All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jeevan.b@intel.com, "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH i-g-t] tests/kms_vrr: Set VRR_ENABLED property as false for non-VRR panel as well
Date: Thu, 14 Nov 2024 13:14:45 +0200	[thread overview]
Message-ID: <20241114111445.3249373-1-jouni.hogander@intel.com> (raw)

Currently we are facing problems with PSR testcases after running
negative-basic subtest. These are because VRR_ENABLED property is left
enabled by negative-basic subtest and having VRR enabled disables PSR
currently. Fix this by setting the property as false for non-VRR panel as
well.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 tests/kms_vrr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index d0db954fa..830fd8ba8 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -862,8 +862,7 @@ test_cmrr(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
 
 static void test_cleanup(data_t *data, enum pipe pipe, igt_output_t *output)
 {
-	if (vrr_capable(output))
-		igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED, false);
+	igt_pipe_set_prop_value(&data->display, pipe, IGT_CRTC_VRR_ENABLED, false);
 
 	igt_plane_set_fb(data->primary, NULL);
 	igt_output_set_pipe(output, PIPE_NONE);
-- 
2.34.1


             reply	other threads:[~2024-11-14 11:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 11:14 Jouni Högander [this message]
2024-11-14 13:31 ` ✓ CI.xeBAT: success for tests/kms_vrr: Set VRR_ENABLED property as false for non-VRR panel as well Patchwork
2024-11-14 13:40 ` ✓ Fi.CI.BAT: " Patchwork
2024-11-14 18:02 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-15  7:08   ` Hogander, Jouni
2024-11-15  1:01 ` ✗ CI.xeFULL: " Patchwork
2024-11-15  7:15   ` Hogander, Jouni
2024-11-15  6:06 ` [PATCH i-g-t] " Sharma, Swati2
2024-11-15  7:20   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241114111445.3249373-1-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.