Re: [meta-ti][master/scarthgap][PATCH v1] meta-ti: Linux configs: Bring selinux related configs

[Denys Dmytriyenko <denis@denix.org>]

There are several issues with the patch itself, but that is secondary.

The primary issue is that this adds a new layer dependency to meta-ti-bsp 
(which is also not explicitly configured in layer.conf) - that is a very 
undesirable thing for a BSP layer.

This should be done in a Distro or Product layer (I'm not even shure 
meta-arago-distro should have this by default, to be honest).


On Thu, Nov 14, 2024 at 11:18:08AM +0530, Aashvij Shenai via lists.yoctoproject.org wrote:
> Kernel configs that are important for SELinux to be included in the
> Linux kernel are present in the meta-selinux layer.
> 
> Ideally, we wouldn't want to be calling a file from another
> layer since it would become messy. However, bringing those configs
> into meta-ti layer would hit maintainbility issues.
> 
> The root cause of this problem lies in the recipe name. While
> meta-selinux names their bbapend as linux_yocto_%.bbappend, TI has their
> recipe named as linux-ti-staging_%.bb
> 
> Signed-off-by: Aashvij Shenai <a-shenai@ti.com>
> ---
>  .../linux/linux-ti-staging_%.bbappend             | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_%.bbappend
> 
> diff --git a/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_%.bbappend b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_%.bbappend
> new file mode 100644
> index 00000000..460df5de
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-kernel/linux/linux-ti-staging_%.bbappend
> @@ -0,0 +1,15 @@
> +# The meta-selinux layer includes an selinux.cfg file containing
> +# configs necessary for the Linux kernel to enable SELinux
> +
> +# In order to reduce maintainability issues, the file will 
> +# be retained in meta-selinux layer
> +
> +FILESEXTRAPATHS:prepend := "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', '${TOPDIR}/../sources/meta-selinux/recipes-kernel/linux/files:', '', d)}"
> +
> +SRC_URI += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'file://selinux.cfg', '', d)}"
> +
> +do_configure:append() {
> +    if echo "${DISTRO_FEATURES}" | grep -q "selinux"; then
> +        cat ${WORKDIR}/selinux.cfg >> ${B}/.config
> +    fi
> +}
> \ No newline at end of file
> -- 
> 2.34.1
>