From: Jakub Kicinski <kuba@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
upstream@airoha.com
Subject: Re: [net-next PATCH v5 3/4] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver
Date: Thu, 14 Nov 2024 19:22:02 -0800 [thread overview]
Message-ID: <20241114192202.215869ed@kernel.org> (raw)
In-Reply-To: <20241112204743.6710-4-ansuelsmth@gmail.com>
On Tue, 12 Nov 2024 21:47:26 +0100 Christian Marangi wrote:
> + MIB_DESC(1, 0x00, "TxDrop"),
> + MIB_DESC(1, 0x04, "TxCrcErr"),
What is a CRC Tx error :o
Just out of curiosity, not saying its worng.
> + MIB_DESC(1, 0x08, "TxUnicast"),
> + MIB_DESC(1, 0x0c, "TxMulticast"),
> + MIB_DESC(1, 0x10, "TxBroadcast"),
> + MIB_DESC(1, 0x14, "TxCollision"),
Why can't these be rtnl stats, please keep in mind that we ask that
people don't duplicate in ethtool -S what can be exposed via standard
stats
> + MIB_DESC(1, 0x18, "TxSingleCollision"),
> + MIB_DESC(1, 0x1c, "TxMultipleCollision"),
> + MIB_DESC(1, 0x20, "TxDeferred"),
> + MIB_DESC(1, 0x24, "TxLateCollision"),
> + MIB_DESC(1, 0x28, "TxExcessiveCollistion"),
> + MIB_DESC(1, 0x2c, "TxPause"),
> + MIB_DESC(1, 0x30, "TxPktSz64"),
> + MIB_DESC(1, 0x34, "TxPktSz65To127"),
> + MIB_DESC(1, 0x38, "TxPktSz128To255"),
> + MIB_DESC(1, 0x3c, "TxPktSz256To511"),
> + MIB_DESC(1, 0x40, "TxPktSz512To1023"),
> + MIB_DESC(1, 0x44, "TxPktSz1024To1518"),
> + MIB_DESC(1, 0x48, "TxPktSz1519ToMax"),
we have standard stats for rmon, too
> + MIB_DESC(2, 0x4c, "TxBytes"),
> + MIB_DESC(1, 0x54, "TxOversizeDrop"),
> + MIB_DESC(2, 0x58, "TxBadPktBytes"),
> + MIB_DESC(1, 0x80, "RxDrop"),
> + MIB_DESC(1, 0x84, "RxFiltering"),
> + MIB_DESC(1, 0x88, "RxUnicast"),
> + MIB_DESC(1, 0x8c, "RxMulticast"),
> + MIB_DESC(1, 0x90, "RxBroadcast"),
> + MIB_DESC(1, 0x94, "RxAlignErr"),
> + MIB_DESC(1, 0x98, "RxCrcErr"),
> + MIB_DESC(1, 0x9c, "RxUnderSizeErr"),
> + MIB_DESC(1, 0xa0, "RxFragErr"),
> + MIB_DESC(1, 0xa4, "RxOverSzErr"),
> + MIB_DESC(1, 0xa8, "RxJabberErr"),
> + MIB_DESC(1, 0xac, "RxPause"),
> + MIB_DESC(1, 0xb0, "RxPktSz64"),
> + MIB_DESC(1, 0xb4, "RxPktSz65To127"),
> + MIB_DESC(1, 0xb8, "RxPktSz128To255"),
> + MIB_DESC(1, 0xbc, "RxPktSz256To511"),
> + MIB_DESC(1, 0xc0, "RxPktSz512To1023"),
> + MIB_DESC(1, 0xc4, "RxPktSz1024To1518"),
> + MIB_DESC(1, 0xc8, "RxPktSz1519ToMax"),
> + MIB_DESC(2, 0xcc, "RxBytes"),
> + MIB_DESC(1, 0xd4, "RxCtrlDrop"),
> + MIB_DESC(1, 0xd8, "RxIngressDrop"),
> + MIB_DESC(1, 0xdc, "RxArlDrop"),
> + MIB_DESC(1, 0xe0, "FlowControlDrop"),
> + MIB_DESC(1, 0xe4, "WredDrop"),
> + MIB_DESC(1, 0xe8, "MirrorDrop"),
> + MIB_DESC(2, 0xec, "RxBadPktBytes"),
> + MIB_DESC(1, 0xf4, "RxsFlowSamplingPktDrop"),
> + MIB_DESC(1, 0xf8, "RxsFlowTotalPktDrop"),
> + MIB_DESC(1, 0xfc, "PortControlDrop"),
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-15 3:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 20:47 [net-next PATCH v5 0/4] net: dsa: Add Airoha AN8855 support Christian Marangi
2024-11-12 20:47 ` [net-next PATCH v5 1/4] net: dsa: add devm_dsa_register_switch() Christian Marangi
2024-11-17 3:26 ` kernel test robot
2024-11-12 20:47 ` [net-next PATCH v5 2/4] dt-bindings: net: dsa: Add Airoha AN8855 Gigabit Switch documentation Christian Marangi
2024-11-12 20:47 ` [net-next PATCH v5 3/4] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver Christian Marangi
2024-11-15 3:22 ` Jakub Kicinski [this message]
2024-11-15 21:59 ` Christian Marangi
2024-11-15 22:59 ` Jakub Kicinski
2024-11-15 23:03 ` Christian Marangi
2024-11-15 23:15 ` Jakub Kicinski
2024-11-15 23:19 ` Christian Marangi
2024-11-12 20:47 ` [net-next PATCH v5 4/4] net: phy: Add Airoha AN8855 Internal Switch Gigabit PHY Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114192202.215869ed@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.