From: Petr Vorel <petr.vorel@gmail.com>
To: Anssi Hannula <anssi.hannula@bitwise.fi>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/nfs-utils: fix unit dependencies without systemd on build host
Date: Thu, 14 Nov 2024 22:04:45 +0100 [thread overview]
Message-ID: <20241114210445.GA372474@pevik> (raw)
In-Reply-To: <20241106100210.1547916-1-anssi.hannula@bitwise.fi>
Hi Anssi, all,
> nfs-utils configure script uses "systemd-escape" to determine the
> rpc_pipefs mount point unit name in the non-default case.
> If the host build system has no systemd this will silently result in an
> empty name, causing rpc_pipefs.target to incorrectly depend on ".mount".
> Fix that by depending on host-systemd for build.
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
> ---
> package/nfs-utils/nfs-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index b757e3e51d..9ea3bae79d 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -79,7 +79,7 @@ NFS_UTILS_POST_INSTALL_TARGET_HOOKS += NFS_UTILS_INSTALL_FIXUP
> ifeq ($(BR2_INIT_SYSTEMD),y)
> NFS_UTILS_CONF_OPTS += --with-systemd=/usr/lib/systemd/system
> -NFS_UTILS_DEPENDENCIES += systemd
> +NFS_UTILS_DEPENDENCIES += systemd host-systemd
Given that majority of the developers use Buildroot with Linux distro with
systemd I'm not happy about all of then need to build host-systemd.
Is there any better solution for this? If not let's fix the problem with
accepting the dependency.
Acked-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
> else
> NFS_UTILS_CONF_OPTS += --without-systemd
> endif
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-11-14 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 10:02 [Buildroot] [PATCH 1/1] package/nfs-utils: fix unit dependencies without systemd on build host Anssi Hannula via buildroot
2024-11-14 21:04 ` Petr Vorel [this message]
2024-12-04 20:29 ` Arnout Vandecappelle via buildroot
2024-11-14 21:42 ` Petr Vorel
2024-12-04 20:31 ` Arnout Vandecappelle via buildroot
2024-12-06 22:25 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114210445.GA372474@pevik \
--to=petr.vorel@gmail.com \
--cc=anssi.hannula@bitwise.fi \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.