From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
ville.syrjala@linux.intel.com
Subject: Re: [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector
Date: Fri, 15 Nov 2024 10:54:56 +0900 [thread overview]
Message-ID: <20241115015456.GL1458936@google.com> (raw)
In-Reply-To: <87cyix6cc5.fsf@intel.com>
On (24/11/14 17:53), Jani Nikula wrote:
> > Ville, we handle intel_ddi_init_dp_connector() failures but not
> > intel_ddi_init_hdmi_connector() failures. Do you recall if there's a
> > reason for that? Something like a dual-mode port where DP works but HDMI
> > gets rejected because of bogus VBT info?
> >
> > My gut feeling is to propagate errors from intel_hdmi_init_connector()
> > and handle them properly in g4x_hdmi_init() and
> > intel_ddi_init_hdmi_connector().
> >
> > Of course, we have cases where hdmi is just not initialized on DDI, and
> > those should be handled. But I don't think hdmi->attached_connector !=
> > NULL is really the right check for that.
>
> I'm hoping [1] would solve the issue.
Hi Jani, I'll reply in that new thread.
prev parent reply other threads:[~2024-11-15 1:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 10:51 [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector Sergey Senozhatsky
2024-10-31 10:57 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-31 10:57 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-31 10:59 ` ✓ CI.KUnit: success " Patchwork
2024-10-31 11:10 ` ✓ CI.Build: " Patchwork
2024-10-31 11:12 ` ✓ CI.Hooks: " Patchwork
2024-10-31 11:14 ` ✗ CI.checksparse: warning " Patchwork
2024-10-31 11:20 ` ✗ Fi.CI.CHECKPATCH: " Patchwork
2024-10-31 11:33 ` [RFC][PATCH] " Jani Nikula
2024-10-31 13:43 ` Sergey Senozhatsky
2024-10-31 11:36 ` ✓ CI.BAT: success for " Patchwork
2024-10-31 12:10 ` ✓ Fi.CI.BAT: " Patchwork
2024-10-31 14:26 ` ✗ CI.FULL: failure " Patchwork
2024-10-31 18:52 ` ✗ Fi.CI.IGT: " Patchwork
2024-11-13 8:39 ` [RFC][PATCH] " Sergey Senozhatsky
2024-11-13 9:19 ` Jani Nikula
2024-11-14 15:53 ` Jani Nikula
2024-11-15 1:54 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115015456.GL1458936@google.com \
--to=senozhatsky@chromium.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.