All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Lin via Grub-devel <grub-devel@gnu.org>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Gary Lin <glin@suse.com>, Daniel Kiper <daniel.kiper@oracle.com>,
	Hernan Gatta <hegatta@linux.microsoft.com>,
	Daniel Axtens <dja@axtens.net>,
	shkhisti@microsoft.com, jaskaran.khurana@microsoft.com,
	christopher.co@microsoft.com, daniel.mihai@microsoft.com,
	jaredz@redhat.com, development@efficientek.com,
	jejb@linux.ibm.com, mchang@suse.com, patrick.colp@oracle.com,
	Stefan Berger <stefanb@linux.ibm.com>,
	Vladimir Serbinenko <phcoder@gmail.com>
Subject: [PATCH v23 09/33] asn1_test: include asn1_test.h only
Date: Fri, 15 Nov 2024 15:34:37 +0800	[thread overview]
Message-ID: <20241115073506.2784-10-glin@suse.com> (raw)
In-Reply-To: <20241115073506.2784-1-glin@suse.com>

This commit removes all the headers and only uses asn1_test.h.
To avoid including int.h from grub-core/lib/libtasn1-grub/lib/,
CONST_DOWN is defined in reproducers.c.

Signed-off-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 ...7-asn1_test-include-asn1_test.h-only.patch | 164 ++++++++++++++++++
 1 file changed, 164 insertions(+)
 create mode 100644 grub-core/lib/libtasn1-patches/0007-asn1_test-include-asn1_test.h-only.patch

diff --git a/grub-core/lib/libtasn1-patches/0007-asn1_test-include-asn1_test.h-only.patch b/grub-core/lib/libtasn1-patches/0007-asn1_test-include-asn1_test.h-only.patch
new file mode 100644
index 000000000..29b931368
--- /dev/null
+++ b/grub-core/lib/libtasn1-patches/0007-asn1_test-include-asn1_test.h-only.patch
@@ -0,0 +1,164 @@
+From 9cc63a71d6772947127d4d77e135d5fda68ccb8d Mon Sep 17 00:00:00 2001
+From: Gary Lin <glin@suse.com>
+Date: Fri, 16 Aug 2024 14:10:21 +0800
+Subject: [PATCH 07/13] asn1_test: include asn1_test.h only
+
+This commit removes all the headers and only uses asn1_test.h.
+To avoid including int.h from grub-core/lib/libtasn1-grub/lib/,
+CONST_DOWN is defined in reproducers.c.
+
+Signed-off-by: Daniel Axtens <dja@axtens.net>
+Signed-off-by: Gary Lin <glin@suse.com>
+Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
+---
+ grub-core/tests/asn1/tests/CVE-2018-1000654.c   | 4 +---
+ grub-core/tests/asn1/tests/Test_overflow.c      | 7 +------
+ grub-core/tests/asn1/tests/Test_simple.c        | 6 +-----
+ grub-core/tests/asn1/tests/Test_strings.c       | 6 +-----
+ grub-core/tests/asn1/tests/object-id-decoding.c | 6 +-----
+ grub-core/tests/asn1/tests/object-id-encoding.c | 6 +-----
+ grub-core/tests/asn1/tests/octet-string.c       | 6 +-----
+ grub-core/tests/asn1/tests/reproducers.c        | 8 ++------
+ 8 files changed, 9 insertions(+), 40 deletions(-)
+
+diff --git a/grub-core/tests/asn1/tests/CVE-2018-1000654.c b/grub-core/tests/asn1/tests/CVE-2018-1000654.c
+index 0c22b7012..98c2a8b8c 100644
+--- a/grub-core/tests/asn1/tests/CVE-2018-1000654.c
++++ b/grub-core/tests/asn1/tests/CVE-2018-1000654.c
+@@ -22,9 +22,7 @@
+ /* Description: reproducer for CVE-2018-1000654			*/
+ /****************************************************************/
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
++#include "asn1_test.h"
+ #include "CVE-2018-1000654-1_asn1_tab.h"
+ #include "CVE-2018-1000654-2_asn1_tab.h"
+ 
+diff --git a/grub-core/tests/asn1/tests/Test_overflow.c b/grub-core/tests/asn1/tests/Test_overflow.c
+index c61dea4bb..73e9d8c68 100644
+--- a/grub-core/tests/asn1/tests/Test_overflow.c
++++ b/grub-core/tests/asn1/tests/Test_overflow.c
+@@ -20,12 +20,7 @@
+ 
+ /* Written by Simon Josefsson */
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
+-#include <limits.h>
+-
+-#include "libtasn1.h"
++#include "asn1_test.h"
+ 
+ int
+ main (int argc, char **argv)
+diff --git a/grub-core/tests/asn1/tests/Test_simple.c b/grub-core/tests/asn1/tests/Test_simple.c
+index 6cd07e069..3aa8ce21b 100644
+--- a/grub-core/tests/asn1/tests/Test_simple.c
++++ b/grub-core/tests/asn1/tests/Test_simple.c
+@@ -20,11 +20,7 @@
+  *
+  */
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
+-
+-#include "libtasn1.h"
++#include "asn1_test.h"
+ 
+ struct tv
+ {
+diff --git a/grub-core/tests/asn1/tests/Test_strings.c b/grub-core/tests/asn1/tests/Test_strings.c
+index 27f7215e1..c49229af9 100644
+--- a/grub-core/tests/asn1/tests/Test_strings.c
++++ b/grub-core/tests/asn1/tests/Test_strings.c
+@@ -20,11 +20,7 @@
+  *
+  */
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
+-
+-#include "libtasn1.h"
++#include "asn1_test.h"
+ 
+ struct tv
+ {
+diff --git a/grub-core/tests/asn1/tests/object-id-decoding.c b/grub-core/tests/asn1/tests/object-id-decoding.c
+index 06a6c52a2..0a77db752 100644
+--- a/grub-core/tests/asn1/tests/object-id-decoding.c
++++ b/grub-core/tests/asn1/tests/object-id-decoding.c
+@@ -18,11 +18,7 @@
+  *
+  */
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
+-
+-#include "libtasn1.h"
++#include "asn1_test.h"
+ 
+ struct tv
+ {
+diff --git a/grub-core/tests/asn1/tests/object-id-encoding.c b/grub-core/tests/asn1/tests/object-id-encoding.c
+index 1a3396986..e32835830 100644
+--- a/grub-core/tests/asn1/tests/object-id-encoding.c
++++ b/grub-core/tests/asn1/tests/object-id-encoding.c
+@@ -18,11 +18,7 @@
+  *
+  */
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
+-
+-#include "libtasn1.h"
++#include "asn1_test.h"
+ 
+ struct tv
+ {
+diff --git a/grub-core/tests/asn1/tests/octet-string.c b/grub-core/tests/asn1/tests/octet-string.c
+index 69eb18a62..8e803af41 100644
+--- a/grub-core/tests/asn1/tests/octet-string.c
++++ b/grub-core/tests/asn1/tests/octet-string.c
+@@ -20,11 +20,7 @@
+  *
+  */
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
+-
+-#include "libtasn1.h"
++#include "asn1_test.h"
+ 
+ struct tv
+ {
+diff --git a/grub-core/tests/asn1/tests/reproducers.c b/grub-core/tests/asn1/tests/reproducers.c
+index a09d8b021..ce24e0991 100644
+--- a/grub-core/tests/asn1/tests/reproducers.c
++++ b/grub-core/tests/asn1/tests/reproducers.c
+@@ -22,13 +22,9 @@
+ /* Description: run reproducers for several fixed issues        */
+ /****************************************************************/
+ 
+-#include <stdio.h>
+-#include <string.h>
+-#include <stdlib.h>
++#include "asn1_test.h"
+ 
+-#include <libtasn1.h>
+-
+-#include <int.h>
++#define CONST_DOWN        (1U<<29)
+ 
+ /* produces endless loop (fixed by d4b624b2):
+  * The following translates into a single node with all pointers
+-- 
+2.43.0
+
-- 
2.43.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  parent reply	other threads:[~2024-11-15  7:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15  7:34 [PATCH v23 00/33] Automatic Disk Unlock with TPM2 Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 01/33] posix_wrap: tweaks in preparation for libtasn1 Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 02/33] libtasn1: import libtasn1-4.19.0 Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 03/33] libtasn1: disable code not needed in grub Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 04/33] libtasn1: replace strcat() with strcpy() in _asn1_str_cat() Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 05/33] libtasn1: replace strcat() with _asn1_str_cat() Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 06/33] libtasn1: adjust the header paths in libtasn1.h Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 07/33] libtasn1: Use grub_divmod64() for division Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 08/33] libtasn1: fix the potential buffer overrun Gary Lin via Grub-devel
2024-11-15  7:34 ` Gary Lin via Grub-devel [this message]
2024-11-15  7:34 ` [PATCH v23 10/33] asn1_test: rename the main functions to the test names Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 11/33] asn1_test: return either 0 or 1 to reflect the results Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 12/33] asn1_test: remove 'verbose' and the unnecessary printf() Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 13/33] asn1_test: print the error messages with grub_printf() Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 14/33] asn1_test: use the grub-specific functions and types Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 15/33] asn1_test: enable the testcase only when GRUB_LONG_MAX is larger than GRUB_INT_MAX Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 16/33] libtasn1: compile into asn1 module Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 17/33] asn1_test: test module for libtasn1 Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 18/33] libtasn1: Add the documentation Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 19/33] key_protector: Add key protectors framework Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 20/33] tss2: Add TPM2 buffer handling functions Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 21/33] tss2: Add TPM2 types and Marshal/Unmarshal functions Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 22/33] tss2: Add TPM2 Software Stack (TSS2) support Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 23/33] key_protector: Add TPM2 Key Protector Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 24/33] cryptodisk: Support key protectors Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 25/33] util/grub-protect: Add new tool Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 26/33] tpm2_key_protector: Support authorized policy Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 27/33] tpm2_key_protector: Implement NV index Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 28/33] cryptodisk: Fallback to passphrase Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 29/33] cryptodisk: wipe out the cached keys from protectors Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 30/33] diskfilter: look up cryptodisk devices first Gary Lin via Grub-devel
2024-11-15  7:34 ` [PATCH v23 31/33] tpm2_key_protector: Add grub-emu support Gary Lin via Grub-devel
2024-11-15  7:35 ` [PATCH v23 32/33] tests: Add tpm2_key_protector_test Gary Lin via Grub-devel
2024-11-15  7:35 ` [PATCH v23 33/33] docs: Document TPM2 key protector Gary Lin via Grub-devel
2024-11-19 15:15 ` [PATCH v23 00/33] Automatic Disk Unlock with TPM2 Stefan Berger
2024-11-25 17:21   ` Daniel Kiper via Grub-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241115073506.2784-10-glin@suse.com \
    --to=grub-devel@gnu.org \
    --cc=christopher.co@microsoft.com \
    --cc=daniel.kiper@oracle.com \
    --cc=daniel.mihai@microsoft.com \
    --cc=development@efficientek.com \
    --cc=dja@axtens.net \
    --cc=glin@suse.com \
    --cc=hegatta@linux.microsoft.com \
    --cc=jaredz@redhat.com \
    --cc=jaskaran.khurana@microsoft.com \
    --cc=jejb@linux.ibm.com \
    --cc=mchang@suse.com \
    --cc=patrick.colp@oracle.com \
    --cc=phcoder@gmail.com \
    --cc=shkhisti@microsoft.com \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.