From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com,
syzbot+d4373fa8042c06cefa84@syzkaller.appspotmail.com,
dsahern@kernel.org
Subject: Re: [PATCH net 1/2] netlink: fix false positive warning in extack during dumps
Date: Fri, 15 Nov 2024 08:38:16 -0800 [thread overview]
Message-ID: <20241115083816.3040dffe@kernel.org> (raw)
In-Reply-To: <20241115140007.GR1062410@kernel.org>
On Fri, 15 Nov 2024 14:00:07 +0000 Simon Horman wrote:
> > + * nlmsg_addr_in_payload - address points to a byte within the message payload
> > + * @nlh: netlink message header
>
> nit: something about @addr should go here.
Ah, thanks, I just sent a mass conversion, the missing Return
statements make the warnings hard to spot.
I'll also move the warning into the helper in v2, I hate
the double negation in the caller.
--
pw-bot: cr
prev parent reply other threads:[~2024-11-15 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 0:31 [PATCH net 1/2] netlink: fix false positive warning in extack during dumps Jakub Kicinski
2024-11-15 0:31 ` [PATCH net 2/2] selftests: net: test extacks in netlink dumps Jakub Kicinski
2024-11-15 14:00 ` [PATCH net 1/2] netlink: fix false positive warning in extack during dumps Simon Horman
2024-11-15 16:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115083816.3040dffe@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+d4373fa8042c06cefa84@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.