From: Stephen Hemminger <stephen@networkplumber.org>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2-next] add .editorconfig file for basic formatting
Date: Fri, 15 Nov 2024 12:32:10 -0800 [thread overview]
Message-ID: <20241115123210.752b5580@hermes.local> (raw)
In-Reply-To: <31ea1d1b-dbe9-4bc6-8218-64de1884baaf@wanadoo.fr>
On Sat, 16 Nov 2024 02:59:01 +0900
Vincent Mailhol <mailhol.vincent@wanadoo.fr> wrote:
> > [*]
> > end_of_line = lf
> > insert_final_newline = true
> > trim_trailing_whitespace = true
>
> Just let me confirm this one: do you really want the automatic
> whitespace removal? On some editor, it will trim not only the modified
> lines but also any whitespace in the full file.
>
> This can create "noise" in the patch diff. If you acknowledge this risk,
> then I am fine to keep this parameter.
Yes, emacs and some other editors have bad habit of leaving trailing
whitespace. And sometimes new files get added without new line at end.
Line length should be 100 like kernel.
next prev parent reply other threads:[~2024-11-15 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 15:08 [PATCH iproute2-next] add .editorconfig file for basic formatting Vincent Mailhol
2024-11-15 16:49 ` Stephen Hemminger
2024-11-15 17:34 ` Vincent Mailhol
2024-11-15 16:51 ` Stephen Hemminger
2024-11-15 17:59 ` Vincent Mailhol
2024-11-15 20:32 ` Stephen Hemminger [this message]
2024-11-16 2:59 ` Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115123210.752b5580@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.