From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: joro@8bytes.org, kevin.tian@intel.com, baolu.lu@linux.intel.com,
eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org,
chao.p.peng@linux.intel.com, iommu@lists.linux.dev,
zhenzhong.duan@intel.com, vasant.hegde@amd.com, will@kernel.org
Subject: Re: [PATCH v5 1/7] iommu: Prevent pasid attach if no ops->remove_dev_pasid
Date: Fri, 15 Nov 2024 10:58:04 -0400 [thread overview]
Message-ID: <20241115145804.GY35230@nvidia.com> (raw)
In-Reply-To: <20241113134613.7173-2-yi.l.liu@intel.com>
On Wed, Nov 13, 2024 at 05:46:07AM -0800, Yi Liu wrote:
> driver should implement both set_dev_pasid and remove_dev_pasid op, otherwise
> it is a problem how to detach pasid. In reality, it is impossible that an
> iommu driver implements set_dev_pasid() but no remove_dev_pasid() op. However,
> it is better to check it.
>
> Move the group check to be the first as dev_iommu_ops() may fail when there
> is no valid group. Also take the chance to remove the dev_has_iommu() check
> as it is duplicated to the group check.
>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
> drivers/iommu/iommu.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2024-11-15 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 13:46 [PATCH v5 0/7] Support attaching PASID to the blocked_domain Yi Liu
2024-11-13 13:46 ` [PATCH v5 1/7] iommu: Prevent pasid attach if no ops->remove_dev_pasid Yi Liu
2024-11-15 14:58 ` Jason Gunthorpe [this message]
2024-11-13 13:46 ` [PATCH v5 2/7] iommu: Consolidate the ops->remove_dev_pasid usage into a helper Yi Liu
2024-11-13 13:46 ` [PATCH v5 3/7] iommu: Detaching pasid by attaching to the blocked_domain Yi Liu
2024-11-13 13:46 ` [PATCH v5 4/7] iommu/arm-smmu-v3: Make the blocked domain support PASID Yi Liu
2024-11-13 13:46 ` [PATCH v5 5/7] iommu/vt-d: " Yi Liu
2024-11-13 13:46 ` [PATCH v5 6/7] iommu/amd: " Yi Liu
2024-11-13 13:46 ` [PATCH v5 7/7] iommu: Remove the remove_dev_pasid op Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115145804.GY35230@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.