From: Jakub Kicinski <kuba@kernel.org>
To: Xiao Liang <shaw.leon@gmail.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Donald Hunter <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Ido Schimmel <idosch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Jiri Pirko <jiri@resnulli.us>, Hangbin Liu <liuhangbin@gmail.com>,
linux-rdma@vger.kernel.org, linux-can@vger.kernel.org,
osmocom-net-gprs@lists.osmocom.org, bpf@vger.kernel.org,
linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com,
linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
bridge@lists.linux.dev, linux-wpan@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/6] rtnetlink: Decouple net namespaces in rtnl_newlink_create()
Date: Fri, 15 Nov 2024 15:35:26 -0800 [thread overview]
Message-ID: <20241115153526.3582ebcd@kernel.org> (raw)
In-Reply-To: <20241113125715.150201-5-shaw.leon@gmail.com>
On Wed, 13 Nov 2024 20:57:13 +0800 Xiao Liang wrote:
> +/**
> + * struct rtnl_link_nets - net namespace context of newlink.
> + *
> + * @src_net: Source netns of rtnetlink socket
> + * @link_net: Link netns by IFLA_LINK_NETNSID, NULL if not specified.
> + */
> +struct rtnl_link_nets {
> + struct net *src_net;
> + struct net *link_net;
> +};
Let's not limit ourselves to passing just netns via this struct.
Let's call it rtnl_newlink_args or params.
The first patch of the series got merged independently so you'll
need to respin.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-15 23:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 12:57 [PATCH net-next v3 0/6] net: Improve netns handling in RTNL and ip_tunnel Xiao Liang
2024-11-13 12:57 ` [PATCH net-next v3 1/6] Revert "tools/net/ynl: improve async notification handling" Xiao Liang
2024-11-13 12:57 ` [PATCH net-next v3 2/6] net: ip_tunnel: Build flow in underlay net namespace Xiao Liang
2024-11-13 12:57 ` [PATCH net-next v3 3/6] rtnetlink: Lookup device in target netns when creating link Xiao Liang
2024-11-13 12:57 ` [PATCH net-next v3 4/6] rtnetlink: Decouple net namespaces in rtnl_newlink_create() Xiao Liang
2024-11-15 23:35 ` Jakub Kicinski [this message]
2024-11-13 12:57 ` [PATCH net-next v3 5/6] selftests: net: Add python context manager for netns entering Xiao Liang
2024-11-13 12:57 ` [PATCH net-next v3 6/6] selftests: net: Add two test cases for link netns Xiao Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115153526.3582ebcd@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuniyu@amazon.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=shaw.leon@gmail.com \
--cc=shuah@kernel.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.