All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roque Arcudia Hernandez <roqueh@google.com>
To: peter.maydell@linaro.org, farosas@suse.de, lvivier@redhat.com,
	 slongfield@google.com, komlodi@google.com, pbonzini@redhat.com,
	 venture@google.com
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	 Roque Arcudia Hernandez <roqueh@google.com>
Subject: [PATCH 4/5] tests/qtest/cmsdk-apb-watchdog-test: Don't abort on assertion failure
Date: Fri, 15 Nov 2024 16:03:27 +0000	[thread overview]
Message-ID: <20241115160328.1650269-5-roqueh@google.com> (raw)
In-Reply-To: <20241115160328.1650269-1-roqueh@google.com>

Currently the watchdog test has a behavior in which the first test
assertion that fails will make the test abort making it impossible to
see the result of other tests:

 # ERROR:../tests/qtest/cmsdk-apb-watchdog-test.c:87:test_watchdog:
 assertion failed ...
 Bail out!
 Aborted

Changing the behavior in order to let the test finish other tests and
report the ones that pass and fail:

 # ERROR:../tests/qtest/cmsdk-apb-watchdog-test.c:101:test_watchdog:
 assertion failed ...
 not ok 1 /arm/cmsdk-apb-watchdog/watchdog

Signed-off-by: Roque Arcudia Hernandez <roqueh@google.com>
---
 tests/qtest/cmsdk-apb-watchdog-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/cmsdk-apb-watchdog-test.c b/tests/qtest/cmsdk-apb-watchdog-test.c
index bdf6cfa256..fe535a553c 100644
--- a/tests/qtest/cmsdk-apb-watchdog-test.c
+++ b/tests/qtest/cmsdk-apb-watchdog-test.c
@@ -164,6 +164,7 @@ int main(int argc, char **argv)
     int r;
 
     g_test_init(&argc, &argv, NULL);
+    g_test_set_nonfatal_assertions();
 
     if (qtest_has_machine(machine_info[MACHINE_LM3S811EVB].machine)) {
         qtest_add_data_func("/cmsdk-apb-watchdog/watchdog",
-- 
2.47.0.338.g60cca15819-goog


  parent reply	other threads:[~2024-11-15 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15 16:03 [PATCH 0/5] Make WDOGCONTROL.INTEN the counter enable of the CMSDK APB Watchdog Roque Arcudia Hernandez
2024-11-15 16:03 ` [PATCH 1/5] hw/watchdog/cmsdk_apb_watchdog: Fix broken link Roque Arcudia Hernandez
2024-11-15 16:36   ` Philippe Mathieu-Daudé
2024-11-15 16:03 ` [PATCH 2/5] hw/watchdog/cmsdk_apb_watchdog: Fix INTEN issues Roque Arcudia Hernandez
2024-11-15 16:03 ` [PATCH 3/5] tests/qtest/cmsdk-apb-watchdog-test: Parameterize tests Roque Arcudia Hernandez
2024-11-15 16:03 ` Roque Arcudia Hernandez [this message]
2024-11-15 16:03 ` [PATCH 5/5] tests/qtest/cmsdk-apb-watchdog-test: Test INTEN as counter enable Roque Arcudia Hernandez
2024-11-15 17:21 ` [PATCH 0/5] Make WDOGCONTROL.INTEN the counter enable of the CMSDK APB Watchdog Roque Arcudia Hernandez
2024-11-15 17:25   ` Peter Maydell
2024-11-18 13:20 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241115160328.1650269-5-roqueh@google.com \
    --to=roqueh@google.com \
    --cc=farosas@suse.de \
    --cc=komlodi@google.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=slongfield@google.com \
    --cc=venture@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.