From: Jakub Kicinski <kuba@kernel.org>
To: Divya Koppera <divya.koppera@microchip.com>
Cc: <andrew@lunn.ch>, <arun.ramadoss@microchip.com>,
<UNGLinuxDriver@microchip.com>, <hkallweit1@gmail.com>,
<linux@armlinux.org.uk>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<richardcochran@gmail.com>, <vadim.fedorenko@linux.dev>
Subject: Re: [PATCH net-next v4 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in Microchip phys
Date: Fri, 15 Nov 2024 16:36:31 -0800 [thread overview]
Message-ID: <20241115163631.636927b0@kernel.org> (raw)
In-Reply-To: <20241114120455.5413-4-divya.koppera@microchip.com>
On Thu, 14 Nov 2024 17:34:53 +0530 Divya Koppera wrote:
> config MICROCHIP_T1_PHY
> tristate "Microchip T1 PHYs"
> + select MICROCHIP_PHYPTP if NETWORK_PHY_TIMESTAMPING
> + depends on PTP_1588_CLOCK_OPTIONAL
I presume the dependency is because select doesn't obey
dependencies, but you only select PHYPTP if NETWORK_PHY_TIMESTAMPING.
Maybe it's possible to create a intermediate meta-symbol which is
NETWORK_PHY_TIMESTAMPING && PTP_1588_CLOCK_OPTIONAL
and use that in the select.. if ... clause?
> + help
> + Supports the LAN8XXX PHYs.
> +
> +config MICROCHIP_PHYPTP
> + tristate "Microchip PHY PTP"
> help
nit: tabs vs spaces
> - Supports the LAN87XX PHYs.
> + Currently supports LAN887X T1 PHY
This Kconfig is likely unsafe.
You have to make sure PHYPTP is not a module when T1_PHY is built in.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-16 0:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 12:04 [PATCH net-next v4 0/5] Add ptp library for Microchip phys Divya Koppera
2024-11-14 12:04 ` [PATCH net-next v4 1/5] net: phy: microchip_ptp : Add header file for Microchip ptp library Divya Koppera
2024-11-14 14:15 ` Vadim Fedorenko
2024-11-16 0:37 ` Jakub Kicinski
2024-11-14 12:04 ` [PATCH net-next v4 2/5] net: phy: microchip_ptp : Add ptp library for Microchip phys Divya Koppera
2024-11-14 14:18 ` Vadim Fedorenko
2024-11-14 12:04 ` [PATCH net-next v4 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in " Divya Koppera
2024-11-14 14:19 ` Vadim Fedorenko
2024-11-16 0:36 ` Jakub Kicinski [this message]
2024-11-18 10:46 ` Divya.Koppera
2024-11-14 12:04 ` [PATCH net-next v4 4/5] net: phy: Makefile: Add makefile support for ptp " Divya Koppera
2024-11-14 14:19 ` Vadim Fedorenko
2024-11-14 12:04 ` [PATCH net-next v4 5/5] net: phy: microchip_t1 : Add initialization of ptp for lan887x Divya Koppera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115163631.636927b0@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=divya.koppera@microchip.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.