From: Nir Lichtman <nir@lichtman.org>
To: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
ebiederm@xmission.com, kees@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] exec: fix no kernel module found error to be more clear
Date: Fri, 15 Nov 2024 16:55:41 +0000 [thread overview]
Message-ID: <20241115165541.GB209124@lichtman.org> (raw)
Problem: Before starting the enumeration of the supported formats the
default return value is set to no entity which is misleading since if
the kernel module of the binary format is not found, it would return no
entity to user mode which is misleading since it is signaling that a
file was not found, but in this case the more suitable error is that the
executable has an unsupported format
Solution: Refactor to return no-exec error instead
Signed-off-by: Nir Lichtman <nir@lichtman.org>
---
fs/exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/exec.c b/fs/exec.c
index 3394de5882af..6324f9546b09 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1740,7 +1740,7 @@ static int search_binary_handler(struct linux_binprm *bprm)
if (retval)
return retval;
- retval = -ENOENT;
+ retval = -ENOEXEC;
retry:
read_lock(&binfmt_lock);
list_for_each_entry(fmt, &formats, lh) {
--
2.39.2
next reply other threads:[~2024-11-15 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 16:55 Nir Lichtman [this message]
2024-11-15 18:03 ` [PATCH] exec: fix no kernel module found error to be more clear Nir Lichtman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115165541.GB209124@lichtman.org \
--to=nir@lichtman.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.