From: Greg KH <gregkh@linuxfoundation.org>
To: Bin Lan <bin.lan.cn@windriver.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 6.1] fs/ntfs3: Fix general protection fault in run_is_mapped_full
Date: Fri, 15 Nov 2024 06:19:43 +0100 [thread overview]
Message-ID: <2024111530-cold-facility-4b7a@gregkh> (raw)
In-Reply-To: <20241114093107.1092295-1-bin.lan.cn@windriver.com>
On Thu, Nov 14, 2024 at 05:31:07PM +0800, Bin Lan wrote:
> From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
>
> [ Upstream commit a33fb016e49e37aafab18dc3c8314d6399cb4727 ]
>
> Fixed deleating of a non-resident attribute in ntfs_create_inode()
> rollback.
>
> Reported-by: syzbot+9af29acd8f27fbce94bc@syzkaller.appspotmail.com
> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
> ---
> fs/ntfs3/inode.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index 026ed43c0670..8d1cfa0fc13f 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -1646,6 +1646,15 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
> le16_to_cpu(new_de->key_size), sbi);
> /* ni_unlock(dir_ni); will be called later. */
> out6:
> + attr = ni_find_attr(ni, NULL, NULL, ATTR_EA, NULL, 0, NULL, NULL);
> + if (attr && attr->non_res) {
> + /* Delete ATTR_EA, if non-resident. */
> + struct runs_tree run;
> + run_init(&run);
> + attr_set_size(ni, ATTR_EA, NULL, 0, &run, 0, NULL, false, NULL);
> + run_close(&run);
> + }
> +
You have trailing whitespace here :(
prev parent reply other threads:[~2024-11-15 5:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 9:31 [PATCH 6.1] fs/ntfs3: Fix general protection fault in run_is_mapped_full Bin Lan
2024-11-15 5:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024111530-cold-facility-4b7a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bin.lan.cn@windriver.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.