From: Greg KH <gregkh@linuxfoundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: stable@vger.kernel.org, Jann Horn <jannh@google.com>,
stable <stable@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 6.6.y] mm: refactor map_deny_write_exec()
Date: Fri, 15 Nov 2024 05:02:29 +0100 [thread overview]
Message-ID: <2024111540-vegan-discard-a481@gregkh> (raw)
In-Reply-To: <20241114183615.849150-1-lorenzo.stoakes@oracle.com>
On Thu, Nov 14, 2024 at 06:36:15PM +0000, Lorenzo Stoakes wrote:
> Refactor the map_deny_write_exec() to not unnecessarily require a VMA
> parameter but rather to accept VMA flags parameters, which allows us to use
> this function early in mmap_region() in a subsequent commit.
>
> While we're here, we refactor the function to be more readable and add some
> additional documentation.
>
> Reported-by: Jann Horn <jannh@google.com>
> Fixes: deb0f6562884 ("mm/mmap: undo ->mmap() when arch_validate_flags() fails")
> Cc: stable <stable@kernel.org>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: Jann Horn <jannh@google.com>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> include/linux/mman.h | 21 ++++++++++++++++++---
> mm/mmap.c | 2 +-
> mm/mprotect.c | 2 +-
> 3 files changed, 20 insertions(+), 5 deletions(-)
There's no clue here as to what the upstream git id is :(
Also, you sent lots of patches for each branch, but not as a series, so
we have no idea what order these go in :(
Can you resend all of these, with the upstream git id in it, and as a
patch series, so we know to apply them correctly?
thanks,
greg k-h
next prev parent reply other threads:[~2024-11-15 4:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 11:38 FAILED: patch "[PATCH] mm: refactor map_deny_write_exec()" failed to apply to 6.6-stable tree gregkh
2024-11-14 18:36 ` [PATCH 6.6.y] mm: refactor map_deny_write_exec() Lorenzo Stoakes
2024-11-15 4:02 ` Greg KH [this message]
2024-11-15 7:52 ` Lorenzo Stoakes
2024-11-15 8:27 ` Greg KH
2024-11-15 8:38 ` Lorenzo Stoakes
2024-11-15 9:20 ` Greg KH
2024-11-15 9:48 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024111540-vegan-discard-a481@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=jannh@google.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.