From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Damien Le Moal <dlemoal@kernel.org>,
stable@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: ep: Fix advertised resizable BAR size again
Date: Sun, 17 Nov 2024 03:14:03 +0900 [thread overview]
Message-ID: <20241116181403.GA890334@rocinante> (raw)
In-Reply-To: <20241116005950.2480427-2-cassel@kernel.org>
Hello,
On 24-11-16 01:59:51, Niklas Cassel wrote:
> The advertised resizable BAR size was fixed in commit 72e34b8593e0 ("PCI:
> dwc: endpoint: Fix advertised resizable BAR size").
>
> Commit 867ab111b242 ("PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API
> to handle Link Down event") was included shortly after this, and moved the
> code to another function. When the code was moved, this fix was mistakenly
> lost.
>
> According to the spec, it is illegal to not have a bit set in
> PCI_REBAR_CAP, and 1 MB is the smallest size allowed.
>
> Set bit 4 in PCI_REBAR_CAP, so that we actually advertise support for a
> 1 MB BAR size.
Applied to controller/dwc, thank you!
[01/01] PCI: dwc: ep: Fix advertised resizable BAR size regression
https://git.kernel.org/pci/pci/c/ead24c08af48
Krzysztof
prev parent reply other threads:[~2024-11-16 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 0:59 [PATCH] PCI: dwc: ep: Fix advertised resizable BAR size again Niklas Cassel
2024-11-16 18:14 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241116181403.GA890334@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.