From: Al Viro <viro@zeniv.linux.org.uk>
To: Jeongjun Park <aha310510@gmail.com>
Cc: brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] fs: prevent data-race due to missing inode_lock when calling vfs_getattr
Date: Sun, 17 Nov 2024 16:55:40 +0000 [thread overview]
Message-ID: <20241117165540.GF3387508@ZenIV> (raw)
In-Reply-To: <20241117163719.39750-1-aha310510@gmail.com>
On Mon, Nov 18, 2024 at 01:37:19AM +0900, Jeongjun Park wrote:
> Many filesystems lock inodes before calling vfs_getattr, so there is no
> data-race for inodes. However, some functions in fs/stat.c that call
> vfs_getattr do not lock inodes, so the data-race occurs.
>
> Therefore, we need to apply a patch to remove the long-standing data-race
> for inodes in some functions that do not lock inodes.
Why do we care? Slapping even a shared lock on a _very_ hot path, with
possible considerable latency, would need more than "theoretically it's
a data race".
next prev parent reply other threads:[~2024-11-17 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 16:37 [PATCH] fs: prevent data-race due to missing inode_lock when calling vfs_getattr Jeongjun Park
2024-11-17 16:55 ` Al Viro [this message]
2024-11-18 6:00 ` Jeongjun Park
2024-11-18 7:03 ` Al Viro
2024-11-20 1:44 ` Mateusz Guzik
2024-11-20 2:08 ` Al Viro
2024-11-20 2:29 ` Mateusz Guzik
2024-11-20 9:19 ` Christian Brauner
2024-11-17 22:52 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241117165540.GF3387508@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=aha310510@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.