[thomas-weissschuh:b4/b4-sysfs-const-bin_attr-cb 70/120] arch/powerpc/platforms/powernv/opal-core.c:431:37: error: use of undeclared identifier 'opal_core_attr'; did you mean 'opalcore_list'?

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/thomas.weissschuh/linux.git b4/b4-sysfs-const-bin_attr-cb
head:   7a315c5c3a11f198244918c63efbc9205fc501a1
commit: a1c827e4a14a8f2484e8d1159351275b5662c2e3 [70/120] opal-core: macro
config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20241118/202411181242.vpadv6Ru-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241118/202411181242.vpadv6Ru-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411181242.vpadv6Ru-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/platforms/powernv/opal-core.c:11:
   In file included from include/linux/memblock.h:12:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> arch/powerpc/platforms/powernv/opal-core.c:431:37: error: use of undeclared identifier 'opal_core_attr'; did you mean 'opalcore_list'?
     431 |         sysfs_remove_bin_file(mpipl_kobj, &opal_core_attr);
         |                                            ^~~~~~~~~~~~~~
         |                                            opalcore_list
   arch/powerpc/platforms/powernv/opal-core.c:70:18: note: 'opalcore_list' declared here
      70 | static LIST_HEAD(opalcore_list);
         |                  ^
   arch/powerpc/platforms/powernv/opal-core.c:632:2: error: use of undeclared identifier 'opal_core_attr'
     632 |         opal_core_attr.size = oc_conf->opalcore_size;
         |         ^
   4 warnings and 2 errors generated.


vim +431 arch/powerpc/platforms/powernv/opal-core.c

6f713d18144ce8 Hari Bathini 2019-09-11  424  
6f713d18144ce8 Hari Bathini 2019-09-11  425  static void opalcore_cleanup(void)
6f713d18144ce8 Hari Bathini 2019-09-11  426  {
6f713d18144ce8 Hari Bathini 2019-09-11  427  	if (oc_conf == NULL)
6f713d18144ce8 Hari Bathini 2019-09-11  428  		return;
6f713d18144ce8 Hari Bathini 2019-09-11  429  
6f713d18144ce8 Hari Bathini 2019-09-11  430  	/* Remove OPAL core sysfs file */
8852c07a881b0a Sourabh Jain 2019-12-11 @431  	sysfs_remove_bin_file(mpipl_kobj, &opal_core_attr);
6f713d18144ce8 Hari Bathini 2019-09-11  432  	oc_conf->ptload_phdr = NULL;
6f713d18144ce8 Hari Bathini 2019-09-11  433  	oc_conf->ptload_cnt = 0;
6f713d18144ce8 Hari Bathini 2019-09-11  434  
6f713d18144ce8 Hari Bathini 2019-09-11  435  	/* free the buffer used for setting up OPAL core */
6f713d18144ce8 Hari Bathini 2019-09-11  436  	if (oc_conf->opalcorebuf) {
6f713d18144ce8 Hari Bathini 2019-09-11  437  		void *end = (void *)((u64)oc_conf->opalcorebuf +
6f713d18144ce8 Hari Bathini 2019-09-11  438  				     oc_conf->opalcorebuf_sz);
6f713d18144ce8 Hari Bathini 2019-09-11  439  
6f713d18144ce8 Hari Bathini 2019-09-11  440  		free_reserved_area(oc_conf->opalcorebuf, end, -1, NULL);
6f713d18144ce8 Hari Bathini 2019-09-11  441  		oc_conf->opalcorebuf = NULL;
6f713d18144ce8 Hari Bathini 2019-09-11  442  		oc_conf->opalcorebuf_sz = 0;
6f713d18144ce8 Hari Bathini 2019-09-11  443  	}
6f713d18144ce8 Hari Bathini 2019-09-11  444  
6f713d18144ce8 Hari Bathini 2019-09-11  445  	kfree(oc_conf);
6f713d18144ce8 Hari Bathini 2019-09-11  446  	oc_conf = NULL;
6f713d18144ce8 Hari Bathini 2019-09-11  447  }
6f713d18144ce8 Hari Bathini 2019-09-11  448  __exitcall(opalcore_cleanup);
6f713d18144ce8 Hari Bathini 2019-09-11  449  

:::::: The code at line 431 was first introduced by commit
:::::: 8852c07a881b0acfd3d75cf3927adaab815c4ee5 powerpc/powernv: Move core and fadump_release_opalcore under new kobject

:::::: TO: Sourabh Jain <sourabhjain@linux.ibm.com>
:::::: CC: Michael Ellerman <mpe@ellerman.id.au>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki