From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv3 3/3] nvme-pci: use sgls for all user requests if possible
Date: Mon, 18 Nov 2024 17:28:49 +0100 [thread overview]
Message-ID: <20241118162849.GC12281@lst.de> (raw)
In-Reply-To: <20241118155738.2737423-4-kbusch@meta.com>
On Mon, Nov 18, 2024 at 07:57:38AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> If the device supports SGLs, use these for all user requests. This
> format encodes the expected transfer length so it can catch short buffer
> errors in a user command, whether it occurred accidently or maliciously.
>
> For controllers that support SGL data mode, this is a viable mitigation
> to CVE-2023-6238. For controllers that don't support SGL, log a warning
> in the passthrough path since not having the capability can corrupt
> data if the interface is not use correctly.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-11-18 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 15:57 [PATCHv3 0/3] meta sgl and userspace protection Keith Busch
2024-11-18 15:57 ` [PATCHv3 1/3] nvme-pci: add support for sgl metadata Keith Busch
2024-11-18 16:27 ` Christoph Hellwig
2024-11-18 15:57 ` [PATCHv3 2/3] nvme: define the remaining used sgls constants Keith Busch
2024-11-18 16:28 ` Christoph Hellwig
2024-11-18 15:57 ` [PATCHv3 3/3] nvme-pci: use sgls for all user requests if possible Keith Busch
2024-11-18 16:28 ` Christoph Hellwig [this message]
2024-12-02 7:56 ` New warning `nvme nvme0: using unchecked data buffer` (was: [PATCHv3 3/3] nvme-pci: use sgls for all user requests if possible) Paul Menzel
2024-12-02 15:05 ` Keith Busch
2024-12-02 15:15 ` New warning `nvme nvme0: using unchecked data buffer` Paul Menzel
2024-12-02 15:49 ` Keith Busch
2025-01-26 8:37 ` Paul Menzel
2025-01-29 19:00 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118162849.GC12281@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.