From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
max@kutsevol.com, thepacketgeek@gmail.com, vlad.wing@gmail.com,
davej@codemonkey.org.uk
Subject: Re: [PATCH net-next 4/4] netconsole: selftest: Validate CPU number auto-population in userdata
Date: Mon, 18 Nov 2024 18:35:14 -0800 [thread overview]
Message-ID: <20241118183514.112db8b9@kernel.org> (raw)
In-Reply-To: <20241113-netcon_cpu-v1-4-d187bf7c0321@debian.org>
On Wed, 13 Nov 2024 07:10:55 -0800 Breno Leitao wrote:
> + if ! grep -q "cpu=[0-9]\+" "${TMPFILENAME}"; then
> + echo "FAIL: 'cpu=' not found in ${TMPFILENAME}" >&2
> + cat "${TMPFILENAME}" >&2
> + exit "${ksft_fail}"
> + fi
Could we try to do something like pick a 'random' CPU ID from sysfs,
taskset the write / echo, and match that the incoming message has the
expected CPU ID, not just any?
prev parent reply other threads:[~2024-11-19 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 15:10 [PATCH net-next 0/4] netconsole: Add support for CPU population Breno Leitao
2024-11-13 15:10 ` [PATCH net-next 1/4] netconsole: Ensure dynamic_netconsole_mutex is held during userdata update Breno Leitao
2024-11-13 15:10 ` [PATCH net-next 2/4] netconsole: Add option to auto-populate CPU number in userdata Breno Leitao
2024-11-19 2:33 ` Jakub Kicinski
2024-11-19 17:07 ` Breno Leitao
2024-12-04 16:52 ` Breno Leitao
2024-11-13 15:10 ` [PATCH net-next 3/4] netconsole: docs: Add documentation for CPU number auto-population Breno Leitao
2024-11-13 15:10 ` [PATCH net-next 4/4] netconsole: selftest: Validate CPU number auto-population in userdata Breno Leitao
2024-11-19 2:35 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118183514.112db8b9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=thepacketgeek@gmail.com \
--cc=vlad.wing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.