From: Halil Pasic <pasic@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, akrowiak@linux.ibm.com,
jjherne@linux.ibm.com, freude@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@de.ibm.com, svens@linux.ibm.com,
frankja@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com,
seiden@linux.ibm.com, Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] s390/vfio-ap: remove gmap_convert_to_secure from vfio_ap_ops
Date: Mon, 18 Nov 2024 20:05:46 +0100 [thread overview]
Message-ID: <20241118200546.7bf584f4.pasic@linux.ibm.com> (raw)
In-Reply-To: <20241115135611.87836-1-imbrenda@linux.ibm.com>
On Fri, 15 Nov 2024 14:56:11 +0100
Claudio Imbrenda <imbrenda@linux.ibm.com> wrote:
> If the page has been exported, do not re-import it. Imports should
> only be triggered by the guest. The guest will import the page
> automatically when it will need it again, there is no advantage in
> importing it manually.
>
> Moreover, vfio_pin_pages() will take an extra reference on the page and
> thus will cause the import to always fail. The extra reference would be
> dropped only after pointlessly trying to import the page.
>
> Fixes: f88fb1335733 ("s390/vfio-ap: make sure nib is shared")
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
next prev parent reply other threads:[~2024-11-18 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 13:56 [PATCH v1 1/1] s390/vfio-ap: remove gmap_convert_to_secure from vfio_ap_ops Claudio Imbrenda
2024-11-18 19:05 ` Halil Pasic [this message]
2024-11-19 11:24 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118200546.7bf584f4.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.