From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Tomas Glozar <tglozar@redhat.com>, John Kacur <jkacur@redhat.com>,
"lgoncalv@redhat.com" <lgoncalv@redhat.com>,
Furkan Onder <furkanonder@protonmail.com>
Subject: [for-next][PATCH 2/4] tools/rtla: Improve code readability in timerlat_load.py
Date: Mon, 18 Nov 2024 15:14:33 -0500 [thread overview]
Message-ID: <20241118201459.127808078@goodmis.org> (raw)
In-Reply-To: 20241118201431.871648641@goodmis.org
From: furkanonder <furkanonder@protonmail.com>
The enhancements made to timerlat_load.py are intended to improve the
script's robustness and readability.
Summary of the changes:
- Unnecessary semicolons at the end of lines have been removed.
- Parentheses surrounding the if statement checking args.prio have been
eliminated.
- String concatenation for constructing timerlat_path has been replaced
with an f-string.
- Spacing in a multiplication expression has been adjusted for improved
clarity.
Cc: "jkacur@redhat.com" <jkacur@redhat.com>
Cc: "lgoncalv@redhat.com" <lgoncalv@redhat.com>
Link: https://lore.kernel.org/j2B-ted7pv3TaldTyqfIHrMmjq2fVyBFgnu3TskiQJsyRzy9loPTVVJoqHnrCWu5T88MDIFc612jUglH6Sxkdg9LN-I1XuITmoL70uECmus=@protonmail.com
Signed-off-by: Furkan Onder <furkanonder@protonmail.com>
Reviewed-by: Tomas Glozar <tglozar@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
tools/tracing/rtla/sample/timerlat_load.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/tracing/rtla/sample/timerlat_load.py b/tools/tracing/rtla/sample/timerlat_load.py
index 8cc5eb2d2e69..785e9a83539a 100644
--- a/tools/tracing/rtla/sample/timerlat_load.py
+++ b/tools/tracing/rtla/sample/timerlat_load.py
@@ -37,12 +37,12 @@ except:
exit(1)
try:
- os.sched_setaffinity(0, affinity_mask);
+ os.sched_setaffinity(0, affinity_mask)
except:
print("Error setting affinity")
exit(1)
-if (args.prio):
+if args.prio:
try:
param = os.sched_param(int(args.prio))
os.sched_setscheduler(0, os.SCHED_FIFO, param)
@@ -51,21 +51,21 @@ if (args.prio):
exit(1)
try:
- timerlat_path = "/sys/kernel/tracing/osnoise/per_cpu/cpu" + args.cpu + "/timerlat_fd"
+ timerlat_path = f"/sys/kernel/tracing/osnoise/per_cpu/cpu{args.cpu}/timerlat_fd"
timerlat_fd = open(timerlat_path, 'r')
except:
print("Error opening timerlat fd, did you run timerlat -U?")
exit(1)
try:
- data_fd = open("/dev/full", 'r');
+ data_fd = open("/dev/full", 'r')
except:
print("Error opening data fd")
while True:
try:
timerlat_fd.read(1)
- data_fd.read(20*1024*1024)
+ data_fd.read(20 * 1024 * 1024)
except:
print("Leaving")
break
--
2.45.2
next prev parent reply other threads:[~2024-11-18 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 20:14 [for-next][PATCH 0/4] tools/tracing: Last minute updates for 6.13 Steven Rostedt
2024-11-18 20:14 ` [for-next][PATCH 1/4] rtla/timerlat: Do not set params->user_workload with -U Steven Rostedt
2024-11-18 20:14 ` Steven Rostedt [this message]
2024-11-18 20:14 ` [for-next][PATCH 3/4] tools/rtla: Enhance argument parsing in timerlat_load.py Steven Rostedt
2024-11-18 20:14 ` [for-next][PATCH 4/4] tools/rtla: Improve exception handling " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118201459.127808078@goodmis.org \
--to=rostedt@goodmis.org \
--cc=furkanonder@protonmail.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.