From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Carolina Jubran <cjubran@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>,
donald.hunter@gmail.com
Subject: Re: [PATCH net-next V3 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management
Date: Tue, 19 Nov 2024 06:51:18 -0800 [thread overview]
Message-ID: <20241119065118.24936744@kernel.org> (raw)
In-Reply-To: <ZzykxEIYZPjjRbVy@nanopsycho.orion>
On Tue, 19 Nov 2024 15:46:28 +0100 Jiri Pirko wrote:
> >> Not sure. Perhaps Jakub/Donald would know. Ccing.
> >
> >I haven't read full context, but all "nested" arrays are discouraged.
> >Use:
> > multi-attr: true
> >and repeat the entries without wrapping them into another attr.
>
> But we need to use the array index. It looks a bit odd to me to depent
> on the index in multi-attr in general. It is not guaranteed other
> atrributes don't get in the middle. Ordering should be maintained, that
> is ok.
>
> How about to have a nest that contain just one multi-attr attribute?
You can make the entry a nest and put the index inside, if it is
significant.
next prev parent reply other threads:[~2024-11-19 14:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 20:50 [PATCH net-next V3 0/8] net/mlx5: ConnectX-8 SW Steering + Rate management on traffic classes Tariq Toukan
2024-11-17 20:50 ` [PATCH net-next V3 1/8] net/mlx5: DR, expand SWS STE callbacks and consolidate common structs Tariq Toukan
2024-11-17 20:50 ` [PATCH net-next V3 2/8] net/mlx5: DR, add support for ConnectX-8 steering Tariq Toukan
2024-11-17 20:50 ` [PATCH net-next V3 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management Tariq Toukan
2024-11-18 8:37 ` Jiri Pirko
2024-11-18 19:36 ` Carolina Jubran
2024-11-19 9:31 ` Jiri Pirko
2024-11-19 14:33 ` Jakub Kicinski
2024-11-19 14:46 ` Jiri Pirko
2024-11-19 14:51 ` Jakub Kicinski [this message]
2024-11-19 15:12 ` Jiri Pirko
2024-11-17 20:50 ` [PATCH net-next V3 4/8] net/mlx5: Add no-op implementation for setting tc-bw on rate objects Tariq Toukan
2024-11-17 20:50 ` [PATCH net-next V3 5/8] net/mlx5: Add support for new scheduling elements Tariq Toukan
2024-11-17 20:50 ` [PATCH net-next V3 6/8] net/mlx5: Add support for setting tc-bw on nodes Tariq Toukan
2024-11-17 20:50 ` [PATCH net-next V3 7/8] net/mlx5: Add traffic class scheduling support for vport QoS Tariq Toukan
2024-11-17 20:50 ` [PATCH net-next V3 8/8] net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119065118.24936744@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@resnulli.us \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.