Re: [PATCH v2] xfs_io: add support for atomic write statx fields

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Nov 19, 2024 at 02:10:59PM +0000, John Garry wrote:
> On 18/11/2024 23:52, Catherine Hoang wrote:
> >   #include "init.h"
> > @@ -347,6 +351,9 @@ dump_raw_statx(struct statx *stx)
> >   	printf("stat.rdev_minor = %u\n", stx->stx_rdev_minor);
> >   	printf("stat.dev_major = %u\n", stx->stx_dev_major);
> >   	printf("stat.dev_minor = %u\n", stx->stx_dev_minor);
> > +	printf("stat.atomic_write_unit_min = %lld\n", (long long)stx->stx_atomic_write_unit_min);
> > +	printf("stat.atomic_write_unit_max = %lld\n", (long long)stx->stx_atomic_write_unit_max);
> > +	printf("stat.atomic_write_segments_max = %lld\n", (long long)stx->stx_atomic_write_segments_max);
> 
> Is there a special reason to do this casting to long long? We only do that
> for u64 values, I think.

Yeah, I don't think it's necessary here because the stx_atomic values
are __u32.  xfsprogs has a tendency to cast to explicit C types to avoid
lint warnings, particularly because 64-bit values are grossly typedef'd
depending on how long long is.

Now that I see it -- those should be %u and casts to unsigned int.

--D

> Thanks,
> John
>