From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, x86@kernel.org,
kvm@vger.kernel.org, jthoughton@google.com
Subject: Re: [PATCH v2 01/12] objtool: Generic annotation infrastructure
Date: Wed, 20 Nov 2024 09:52:54 +0100 [thread overview]
Message-ID: <20241120085254.GD19989@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241120010424.thsbdwfwz2e7elza@jpoimboe>
On Tue, Nov 19, 2024 at 05:04:24PM -0800, Josh Poimboeuf wrote:
> On Tue, Nov 19, 2024 at 04:31:25PM -0800, Josh Poimboeuf wrote:
> > On Sat, Nov 16, 2024 at 10:33:31AM +0100, Peter Zijlstra wrote:
> > > On Fri, Nov 15, 2024 at 10:38:28AM -0800, Josh Poimboeuf wrote:
> > > > On Mon, Nov 11, 2024 at 12:59:36PM +0100, Peter Zijlstra wrote:
> > > > > +#define ASM_ANNOTATE(x) \
> > > > > + "911:\n\t" \
> > > > > + ".pushsection .discard.annotate,\"M\",@progbits,8\n\t" \
> > > > > + ".long 911b - .\n\t" \
> > > > > + ".long " __stringify(x) "\n\t" \
> > > > > + ".popsection\n\t"
> > > >
> > > > Why mergeable and progbits?
> > >
> > > In order to get sh_entsize ?
> >
> > Is that a guess? If so, it's not very convincing as I don't see what
> > entsize would have to do with it.
>
> Oh, nevermind... I see it's a gas syntax issue.
Not a guess, only mergable gets entsize, and progbits is a required
argument per the syntax in order to specify entsize.
next prev parent reply other threads:[~2024-11-20 8:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 11:59 [PATCH v2 00/12] x86/kvm/emulate: Avoid RET for FASTOPs Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 01/12] objtool: Generic annotation infrastructure Peter Zijlstra
2024-11-15 18:38 ` Josh Poimboeuf
2024-11-16 9:33 ` Peter Zijlstra
2024-11-20 0:31 ` Josh Poimboeuf
2024-11-20 1:04 ` Josh Poimboeuf
2024-11-20 8:52 ` Peter Zijlstra [this message]
2024-11-20 16:03 ` Josh Poimboeuf
2024-11-20 16:03 ` Josh Poimboeuf
2024-11-21 11:46 ` Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 02/12] objtool: Convert ANNOTATE_NOENDBR to ANNOTATE Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 03/12] objtool: Convert ANNOTATE_RETPOLINE_SAFE " Peter Zijlstra
2024-11-15 18:39 ` Josh Poimboeuf
2024-11-16 9:34 ` Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 04/12] objtool: Convert instrumentation_{begin,end}() " Peter Zijlstra
2024-11-15 18:40 ` Josh Poimboeuf
2024-11-16 9:36 ` Peter Zijlstra
2024-11-16 9:51 ` Peter Zijlstra
2024-11-16 10:06 ` Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 05/12] objtool: Convert VALIDATE_UNRET_BEGIN " Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 06/12] objtool: Convert ANNOTATE_IGNORE_ALTERNATIVE " Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 07/12] objtool: Convert ANNOTATE_INTRA_FUNCTION_CALLS " Peter Zijlstra
2024-11-15 18:40 ` Josh Poimboeuf
2024-11-16 9:37 ` Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 08/12] objtool: Collapse annotate sequences Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 09/12] x86/nospec: JMP_NOSPEC Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 10/12] x86,nospec: Simplify {JMP,CALL}_NOSPEC (part 2) Peter Zijlstra
2024-11-15 18:40 ` Josh Poimboeuf
2024-11-16 9:39 ` Peter Zijlstra
2024-11-11 11:59 ` [PATCH v2 11/12] x86/kvm/emulate: Implement test_cc() in C Peter Zijlstra
2024-11-11 17:13 ` Sean Christopherson
2024-11-11 11:59 ` [PATCH v2 12/12] x86/kvm/emulate: Avoid RET for fastops Peter Zijlstra
2024-11-11 16:27 ` Peter Zijlstra
2024-11-11 17:26 ` Sean Christopherson
2024-11-11 18:28 ` Peter Zijlstra
2024-11-15 18:41 ` Josh Poimboeuf
2024-11-16 9:39 ` Peter Zijlstra
2024-11-11 17:27 ` [PATCH v2 00/12] x86/kvm/emulate: Avoid RET for FASTOPs Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120085254.GD19989@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.