From: Paolo Perego <pperego@suse.de>
To: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Dave Penkler <dpenkler@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Kees Bakker <kees@ijzerbout.nl>, Paolo Perego <pperego@suse.de>,
Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] staging:gpib: Fix a dereference before null check issue
Date: Wed, 20 Nov 2024 15:46:53 +0100 [thread overview]
Message-ID: <20241120144653.377795-1-pperego@suse.de> (raw)
This commit fixes a dereference before null check issue discovered by
Coverity (CID 1601566).
The check ad line 1450 suggests that a_priv can be NULL, however it has
been derefenced before, in the interface_to_usbdev() call.
Signed-off-by: Paolo Perego <pperego@suse.de>
---
drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
index bf05fb4a736b..604e13c32dfb 100644
--- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
+++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
@@ -1446,8 +1446,8 @@ static void agilent_82357a_detach(gpib_board_t *board)
mutex_lock(&agilent_82357a_hotplug_lock);
a_priv = board->private_data;
- usb_dev = interface_to_usbdev(a_priv->bus_interface);
if (a_priv) {
+ usb_dev = interface_to_usbdev(a_priv->bus_interface);
if (a_priv->bus_interface) {
agilent_82357a_go_idle(board);
usb_set_intfdata(a_priv->bus_interface, NULL);
--
2.47.0
next reply other threads:[~2024-11-20 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 14:46 Paolo Perego [this message]
2024-11-20 16:42 ` [PATCH] staging: gpib: Fix a dereference before null check issue Markus Elfring
2024-11-20 17:04 ` [PATCH] staging:gpib: " Dan Carpenter
2024-11-20 19:54 ` Kees Bakker
2024-11-21 7:37 ` Dan Carpenter
2024-11-21 14:10 ` Paolo Perego
2024-11-21 14:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120144653.377795-1-pperego@suse.de \
--to=pperego@suse.de \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kees@ijzerbout.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.