All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/pkeys01: use a dummy function instead of function_size
Date: Wed, 20 Nov 2024 18:07:38 +0100	[thread overview]
Message-ID: <20241120170738.GA38310@pevik> (raw)
In-Reply-To: <CAASaF6xyu0kuOZ=PJTb+byWFFJ2U-ap3hdX-YTfDTLQYQgm0Aw@mail.gmail.com>

Hi Jan,

...
> > This could be an alternative to reverting PKEY_DISABLE_EXECUTE test.
> > I haven't tested it yet on 32bit, but since it doesn't rely on any
> > instruction codes I don't expect it to break. An important test
> > would also be ppc64le.

Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM.

NOTE: we have hackweek this week, I guess you get Martin's feedback next week.

> I tested 32bit and ppc64le, both worked fine, so I propose we give this
> a consideration as alternative to Martin's revert.

Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-11-20 17:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15 15:44 [LTP] [PATCH] Revert "pkey01: Adding test for PKEY_DISABLE_EXECUTE" Martin Doucha
2024-11-15 16:06 ` Martin Doucha
2024-11-15 18:58   ` Petr Vorel
2024-11-19 13:11     ` Jan Stancek
2024-11-19 13:31       ` Jan Stancek
2024-11-19 15:47         ` [LTP] [PATCH] syscalls/pkeys01: use a dummy function instead of function_size Jan Stancek
2024-11-20 14:56           ` Jan Stancek
2024-11-20 17:07             ` Petr Vorel [this message]
2024-11-25  3:43           ` Li Wang
2024-11-25 16:20           ` Martin Doucha
2024-11-26  8:05             ` Jan Stancek
2024-11-20 12:57         ` [LTP] [PATCH] Revert "pkey01: Adding test for PKEY_DISABLE_EXECUTE" Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241120170738.GA38310@pevik \
    --to=pvorel@suse.cz \
    --cc=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.