From: Paolo Perego <pperego@suse.de>
To: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Kalle Valo <kvalo@kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
Shaul Triebitz <shaul.triebitz@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Yedidya Benshimol <yedidya.ben.shimol@intel.com>,
Benjamin Berg <benjamin.berg@intel.com>,
Paolo Perego <pperego@suse.de>
Subject: [PATCH] drivers:wireless: Fix a dereference before null check issue
Date: Thu, 21 Nov 2024 18:02:57 +0100 [thread overview]
Message-ID: <20241121170257.275607-1-pperego@suse.de> (raw)
This patch fixes a dereference before null check issue discovered by
Coverity (CID 1601547)
In iwl_mvm_parse_wowlan_info_notif() routine data is checked against
NULL value at line 2501 but it has been dereferenced three lines before
when calculating sizeof() in an assignment.
Signed-off-by: Paolo Perego <pperego@suse.de>
---
drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
index f85c01e04ebf..f733c16ffd8e 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
@@ -2495,8 +2495,7 @@ static void iwl_mvm_parse_wowlan_info_notif(struct iwl_mvm *mvm,
struct iwl_wowlan_status_data *status,
u32 len)
{
- u32 expected_len = sizeof(*data) +
- data->num_mlo_link_keys * sizeof(status->mlo_keys[0]);
+ u32 expected_len = 0;
if (!data) {
IWL_ERR(mvm, "iwl_wowlan_info_notif data is NULL\n");
@@ -2504,6 +2503,8 @@ static void iwl_mvm_parse_wowlan_info_notif(struct iwl_mvm *mvm,
return;
}
+ expected_len = sizeof(*data) + data->num_mlo_link_keys * sizeof(status->mlo_keys[0]);
+
if (len < expected_len) {
IWL_ERR(mvm, "Invalid WoWLAN info notification!\n");
status = NULL;
--
2.47.0
next reply other threads:[~2024-11-21 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 17:02 Paolo Perego [this message]
2024-11-21 17:28 ` [PATCH] drivers:wireless: Fix a dereference before null check issue Johannes Berg
2024-11-21 17:35 ` Paolo Perego
2024-11-21 17:40 ` Johannes Berg
2024-11-22 7:50 ` wireless: " Markus Elfring
2024-11-22 7:25 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121170257.275607-1-pperego@suse.de \
--to=pperego@suse.de \
--cc=benjamin.berg@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=shaul.triebitz@intel.com \
--cc=yedidya.ben.shimol@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.