Re: [PATCH 0/2] Fix device removal order for Apple dart iommu

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On Thu, Nov 21, 2024 at 08:39:26AM +0100, Janne Grunau wrote:
> On Thu, Oct 31, 2024 at 11:48:00PM +0100, Janne Grunau wrote:
> > Starting with v2024.10 dev_iommu_dma_unmap calls during device removal
> > trigger a NULL pointer dereference since the the iommu device is removed
> > before its user. The sparsely used DM_FLAG_VITAL flag is intended for
> > this dependency.
> > This series adds it to the Apple dart iommu driver and implements the
> > two phased device removal to the EFI loader.
> 
> Can we get this two small patches merged? They fix a regression although
> it worked previously just accidentally. The only drivers using
> DM_FLAG_VITAL are clk-rcar-gen3.c, rzg2l-cpg.c and apple_dart.c all used
> on arm SoCs. arch/arm/lib/bootm.c already uses a device_remove call with
> DM_REMOVE_NON_VITAL so adding it to efi_loader looks reasonable as
> regression fix.

Can you please take a look at doing the changes Heinrich suggested I
believe in 2/2 ?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]