From: kernel test robot <lkp@intel.com>
To: Xiao Liang <shaw.leon@gmail.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Jakub Kicinski <kuba@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev, David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Ido Schimmel <idosch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Jiri Pirko <jiri@resnulli.us>, Hangbin Liu <liuhangbin@gmail.com>,
linux-rdma@vger.kernel.org, linux-can@vger.kernel.org,
osmocom-net-gprs@lists.osmocom.org, bpf@vger.kernel.org,
linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com,
linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
bridge@lists.linux.dev, linux-wpan@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 3/5] rtnetlink: Decouple net namespaces in rtnl_newlink_create()
Date: Fri, 22 Nov 2024 05:43:56 +0800 [thread overview]
Message-ID: <202411220516.rokej98E-lkp@intel.com> (raw)
In-Reply-To: <20241118143244.1773-4-shaw.leon@gmail.com>
Hi Xiao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Xiao-Liang/net-ip_tunnel-Build-flow-in-underlay-net-namespace/20241121-112705
base: net-next/main
patch link: https://lore.kernel.org/r/20241118143244.1773-4-shaw.leon%40gmail.com
patch subject: [PATCH net-next v4 3/5] rtnetlink: Decouple net namespaces in rtnl_newlink_create()
config: arc-randconfig-002-20241122 (https://download.01.org/0day-ci/archive/20241122/202411220516.rokej98E-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220516.rokej98E-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411220516.rokej98E-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/batman-adv/soft-interface.c:1075: warning: Function parameter or struct member 'params' not described in 'batadv_softif_newlink'
>> net/batman-adv/soft-interface.c:1075: warning: Excess function parameter 'nets' description in 'batadv_softif_newlink'
>> net/batman-adv/soft-interface.c:1075: warning: Excess function parameter 'dev' description in 'batadv_softif_newlink'
>> net/batman-adv/soft-interface.c:1075: warning: Excess function parameter 'tb' description in 'batadv_softif_newlink'
>> net/batman-adv/soft-interface.c:1075: warning: Excess function parameter 'data' description in 'batadv_softif_newlink'
>> net/batman-adv/soft-interface.c:1075: warning: Excess function parameter 'extack' description in 'batadv_softif_newlink'
vim +1075 net/batman-adv/soft-interface.c
128254ceea6ffe Sven Eckelmann 2020-10-11 1063
128254ceea6ffe Sven Eckelmann 2020-10-11 1064 /**
128254ceea6ffe Sven Eckelmann 2020-10-11 1065 * batadv_softif_newlink() - pre-initialize and register new batadv link
c19808cb1d05d1 Xiao Liang 2024-11-18 1066 * @nets: the applicable net namespaces
128254ceea6ffe Sven Eckelmann 2020-10-11 1067 * @dev: network device to register
128254ceea6ffe Sven Eckelmann 2020-10-11 1068 * @tb: IFLA_INFO_DATA netlink attributes
128254ceea6ffe Sven Eckelmann 2020-10-11 1069 * @data: enum batadv_ifla_attrs attributes
128254ceea6ffe Sven Eckelmann 2020-10-11 1070 * @extack: extended ACK report struct
128254ceea6ffe Sven Eckelmann 2020-10-11 1071 *
128254ceea6ffe Sven Eckelmann 2020-10-11 1072 * Return: 0 if successful or error otherwise.
128254ceea6ffe Sven Eckelmann 2020-10-11 1073 */
c19808cb1d05d1 Xiao Liang 2024-11-18 1074 static int batadv_softif_newlink(struct rtnl_newlink_params *params)
128254ceea6ffe Sven Eckelmann 2020-10-11 @1075 {
c19808cb1d05d1 Xiao Liang 2024-11-18 1076 struct net_device *dev = params->dev;
c19808cb1d05d1 Xiao Liang 2024-11-18 1077 struct nlattr **data = params->data;
a5ad457eea41ef Sven Eckelmann 2020-10-11 1078 struct batadv_priv *bat_priv = netdev_priv(dev);
a5ad457eea41ef Sven Eckelmann 2020-10-11 1079 const char *algo_name;
a5ad457eea41ef Sven Eckelmann 2020-10-11 1080 int err;
a5ad457eea41ef Sven Eckelmann 2020-10-11 1081
a5ad457eea41ef Sven Eckelmann 2020-10-11 1082 if (data && data[IFLA_BATADV_ALGO_NAME]) {
a5ad457eea41ef Sven Eckelmann 2020-10-11 1083 algo_name = nla_data(data[IFLA_BATADV_ALGO_NAME]);
a5ad457eea41ef Sven Eckelmann 2020-10-11 1084 err = batadv_algo_select(bat_priv, algo_name);
a5ad457eea41ef Sven Eckelmann 2020-10-11 1085 if (err)
a5ad457eea41ef Sven Eckelmann 2020-10-11 1086 return -EINVAL;
a5ad457eea41ef Sven Eckelmann 2020-10-11 1087 }
a5ad457eea41ef Sven Eckelmann 2020-10-11 1088
128254ceea6ffe Sven Eckelmann 2020-10-11 1089 return register_netdevice(dev);
128254ceea6ffe Sven Eckelmann 2020-10-11 1090 }
128254ceea6ffe Sven Eckelmann 2020-10-11 1091
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-21 21:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 14:32 [PATCH net-next v4 0/5] net: Improve netns handling in RTNL and ip_tunnel Xiao Liang
2024-11-18 14:32 ` [PATCH net-next v4 1/5] net: ip_tunnel: Build flow in underlay net namespace Xiao Liang
2024-11-18 14:32 ` [PATCH net-next v4 2/5] rtnetlink: Lookup device in target netns when creating link Xiao Liang
2024-11-18 14:32 ` [PATCH net-next v4 3/5] rtnetlink: Decouple net namespaces in rtnl_newlink_create() Xiao Liang
2024-11-21 21:43 ` kernel test robot [this message]
2024-11-18 14:32 ` [PATCH net-next v4 4/5] selftests: net: Add python context manager for netns entering Xiao Liang
2024-11-18 14:32 ` [PATCH net-next v4 5/5] selftests: net: Add two test cases for link netns Xiao Liang
2024-11-19 3:07 ` [PATCH net-next v4 0/5] net: Improve netns handling in RTNL and ip_tunnel Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411220516.rokej98E-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux.dev \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=shaw.leon@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.