Re: [PATCH v2 1/3] net/macb: add new driver

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue,  5 Nov 2024 08:41:38 +0000
liwencheng <liwencheng@phytium.com.cn> wrote:

> +struct phy_driver genphy_driver = {
> +	.phy_id		= 0xffffffff,
> +	.phy_id_mask	= 0xffffffff,
> +	.name		= "Generic PHY",
> +	.soft_reset	= genphy_soft_reset,
> +	.suspend	= genphy_suspend,
> +	.resume		= genphy_resume,
> +	.check_for_link		= genphy_check_for_link,
> +	.read_status		= genphy_read_status,
> +	.force_speed_duplex = genphy_force_speed_duplex,
> +};
> +
> +struct phy_driver macb_gbe_pcs_driver = {
> +	.phy_id		= 0xffffffff,
> +	.phy_id_mask	= 0xffffffff,
> +	.name		= "Macb gbe pcs PHY",
> +	.soft_reset	= NULL,
> +	.suspend	= NULL,
> +	.resume		= NULL,
> +	.check_for_link		= macb_gbe_pcs_check_for_link,
> +	.read_status		= NULL,
> +	.force_speed_duplex = NULL,
> +};
> +
> +struct phy_driver macb_usxgmii_pcs_driver = {
> +	.phy_id		= 0xffffffff,
> +	.phy_id_mask	= 0xffffffff,
> +	.name		= "Macb usxgmii pcs PHY",
> +	.soft_reset	= NULL,
> +	.suspend	= macb_usxgmii_pcs_suspend,
> +	.resume		= macb_usxgmii_pcs_resume,
> +	.check_for_link		= macb_usxgmii_pcs_check_for_link,
> +	.read_status		= NULL,
> +	.force_speed_duplex = NULL,
> +};

Can these be const and static?