From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: require FMODE_WRITE for F_SET_RW_HINT
Date: Fri, 22 Nov 2024 17:15:47 +0100 [thread overview]
Message-ID: <20241122161547.GA7787@lst.de> (raw)
In-Reply-To: <20241122125342.vmmjokiilvnuifuf@quack3>
On Fri, Nov 22, 2024 at 01:53:42PM +0100, Jan Kara wrote:
> Here I'm not so sure. Firstly, since you are an owner this doesn't add any
> additional practical restriction. Secondly, you are not changing anything
> on disk, just IO hints in memory... Thirdly, we generally don't require
> writeable fd even to do file attribute changes (like with fchmod, fchown,
> etc.). So although the check makes some sense, it seems to be mostly
> inconsistent with how we treat similar stuff.
As I said I'm not quite convince either, so just doing the first one
is probably fine.
next prev parent reply other threads:[~2024-11-22 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 12:29 permission checking for F_SET_RW_HINT Christoph Hellwig
2024-11-22 12:29 ` [PATCH 1/2] fs: require inode_owner_or_capable " Christoph Hellwig
2024-11-22 12:45 ` Jan Kara
2024-11-25 14:16 ` Christian Brauner
2024-11-25 14:17 ` (subset) " Christian Brauner
2024-11-22 12:29 ` [PATCH 2/2] fs: require FMODE_WRITE " Christoph Hellwig
2024-11-22 12:53 ` Jan Kara
2024-11-22 16:15 ` Christoph Hellwig [this message]
2024-11-22 16:40 ` Matthew Wilcox
2024-11-25 14:23 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241122161547.GA7787@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.