Re: [PATCH v2 2/3] mm: convert mm_lock_seq to a proper seqcount

[kernel test robot <lkp@intel.com>]

Hi Suren,

kernel test robot noticed the following build errors:

[auto build test ERROR on 43fb83c17ba2d63dfb798f0be7453ed55ca3f9c2]

url:    https://github.com/intel-lab-lkp/linux/commits/Suren-Baghdasaryan/mm-convert-mm_lock_seq-to-a-proper-seqcount/20241122-003050
base:   43fb83c17ba2d63dfb798f0be7453ed55ca3f9c2
patch link:    https://lore.kernel.org/r/20241121162826.987947-2-surenb%40google.com
patch subject: [PATCH v2 2/3] mm: convert mm_lock_seq to a proper seqcount
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241123/202411230014.xk4U56vk-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241123/202411230014.xk4U56vk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411230014.xk4U56vk-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/asm-generic/rwonce.h:27,
                    from ./arch/sh/include/generated/asm/rwonce.h:1,
                    from include/linux/compiler.h:317,
                    from include/linux/export.h:5,
                    from include/linux/linkage.h:7,
                    from arch/sh/include/asm/bug.h:5,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/mm.h:6,
                    from arch/sh/kernel/asm-offsets.c:14:
   include/linux/mmap_lock.h: In function 'vma_end_write_all':
>> include/linux/mmap_lock.h:140:35: error: 'struct mm_struct' has no member named 'mm_lock_seq'
     140 |         ASSERT_EXCLUSIVE_WRITER(mm->mm_lock_seq);
         |                                   ^~
   include/linux/kcsan-checks.h:371:32: note: in definition of macro 'ASSERT_EXCLUSIVE_WRITER'
     371 |         __kcsan_check_access(&(var), sizeof(var), KCSAN_ACCESS_ASSERT)
         |                                ^~~
>> include/linux/mmap_lock.h:140:35: error: 'struct mm_struct' has no member named 'mm_lock_seq'
     140 |         ASSERT_EXCLUSIVE_WRITER(mm->mm_lock_seq);
         |                                   ^~
   include/linux/kcsan-checks.h:371:45: note: in definition of macro 'ASSERT_EXCLUSIVE_WRITER'
     371 |         __kcsan_check_access(&(var), sizeof(var), KCSAN_ACCESS_ASSERT)
         |                                             ^~~
   make[3]: *** [scripts/Makefile.build:102: arch/sh/kernel/asm-offsets.s] Error 1
   make[3]: Target 'prepare' not remade because of errors.
   make[2]: *** [Makefile:1203: prepare0] Error 2
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:224: __sub-make] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:224: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +140 include/linux/mmap_lock.h

   128	
   129	/*
   130	 * Drop all currently-held per-VMA locks.
   131	 * This is called from the mmap_lock implementation directly before releasing
   132	 * a write-locked mmap_lock (or downgrading it to read-locked).
   133	 * This should normally NOT be called manually from other places.
   134	 * If you want to call this manually anyway, keep in mind that this will release
   135	 * *all* VMA write locks, including ones from further up the stack.
   136	 */
   137	static inline void vma_end_write_all(struct mm_struct *mm)
   138	{
   139		mmap_assert_write_locked(mm);
 > 140		ASSERT_EXCLUSIVE_WRITER(mm->mm_lock_seq);
   141		mm_lock_seqcount_end(mm);
   142	}
   143	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki