All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: =?unknown-8bit?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [mic:landlock-audit 10/23] security/landlock/audit.c:173: warning: Function parameter or struct member 'domain' not described in 'landlock_log_drop_domain'
Date: Sat, 23 Nov 2024 06:48:31 +0800	[thread overview]
Message-ID: <202411230624.KoxUNDEM-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mic/linux.git landlock-audit
head:   6da405a874858ad3a79d8762b442678e046e1111
commit: 170c11a69d564164a7a6458a12d98f76c9cabb23 [10/23] landlock: Log domain properties and release
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241123/202411230624.KoxUNDEM-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241123/202411230624.KoxUNDEM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411230624.KoxUNDEM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> security/landlock/audit.c:173: warning: Function parameter or struct member 'domain' not described in 'landlock_log_drop_domain'


vim +173 security/landlock/audit.c

   161	
   162	/**
   163	 * landlock_log_drop_domain - Create an audit record when a domain is deleted
   164	 *
   165	 * Only domains which previously appeared in the audit logs are logged again.
   166	 * This is useful to know when a domain will never show again in the audit log.
   167	 *
   168	 * This record is not directly tied to a syscall entry.
   169	 *
   170	 * Called by the cred_free() hook, in an uninterruptible context.
   171	 */
   172	void landlock_log_drop_domain(const struct landlock_ruleset *const domain)
 > 173	{
   174		struct audit_buffer *ab;
   175	
   176		if (WARN_ON_ONCE(!domain->hierarchy))
   177			return;
   178	
   179		if (!audit_enabled)
   180			return;
   181	
   182		/* Ignores domains that were not logged.  */
   183		if (READ_ONCE(domain->hierarchy->log_status) != LANDLOCK_LOG_RECORDED)
   184			return;
   185	
   186		ab = audit_log_start(audit_context(), GFP_ATOMIC,
   187				     AUDIT_LANDLOCK_DOM_DROP);
   188		if (!ab)
   189			return;
   190	
   191		audit_log_format(ab, "domain=%llx", domain->hierarchy->id);
   192		audit_log_end(ab);
   193	}
   194	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-11-22 22:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202411230624.KoxUNDEM-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=mic@digikod.net \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.