All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mithil Bavishi <bavishimithil@gmail.com>
To: andreas@kemnade.info
Cc: Laurent.pinchart@ideasonboard.com, aaro.koskinen@iki.fi,
	airlied@gmail.com, bavishimithil@gmail.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	jernej.skrabec@gmail.com, jonas@kwiboo.se, khilman@baylibre.com,
	krzk+dt@kernel.org, linux-hardening@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	neil.armstrong@linaro.org,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	quic_jesszhan@quicinc.com, rfoss@kernel.org, robh@kernel.org,
	rogerq@kernel.org, simona@ffwll.ch, thierry.reding@gmail.com,
	tony@atomide.com, tzimmermann@suse.de
Subject: Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1
Date: Sat, 23 Nov 2024 17:52:58 +0000	[thread overview]
Message-ID: <20241123175259.775-1-bavishimithil@gmail.com> (raw)
In-Reply-To: <20241112114818.1eb238e9@akair>

> > +&i2c3 {
> > +	touchscreen: synaptics-rmi4-i2c@20 {
>
> touchscreen@20
Fixed, generic node names right!

> > +		avdd-supply = <&reg_touch_ldo_en>;
> not known in schema
I cannot seem to find the "vio-supply" shown in the bindings. There is
only mention of avdd-supply and vdd-supply. I am not sure if avdd and
vio are equivalent, hence the confusion.
What should be the solution here?

> Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml:
> horizontal resolution of touchscreen (maximum x coordinate reported + 1)

> So this touchscreen reports max 1278?

Fixed it as well, 1280 and 800 respectively.
https://github.com/Unlegacy-Android/android_kernel_ti_omap4/blob/3.4/common/arch/arm/mach-omap2/board-espresso-input.c#L264

> And these things belong below rm4-f11 according to
> Documentation/devicetree/bindings/input/syna,rmi4.yaml

I did not quite understand what you mean by this. I checked the bindings 
and a few examples, there is nothing "below" rmi4-f11.

Best Regards,
Mithil

  reply	other threads:[~2024-11-23 17:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 20:04 [PATCH v3 00/10] Initial support for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-11-08 20:04 ` [PATCH v3 01/10] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Mithil Bavishi
2024-11-08 20:04 ` [PATCH v3 02/10] dt-bindings: vendor-prefixes: Add Doestek Mithil Bavishi
2024-11-09 10:32   ` Krzysztof Kozlowski
2024-11-08 20:04 ` [PATCH v3 03/10] dt-bindings: display: bridge: lvds-codec: add doestek,dtc34lm85am Mithil Bavishi
2024-11-08 20:04   ` [PATCH v3 03/10] dt-bindings: display: bridge: lvds-codec: add doestek, dtc34lm85am Mithil Bavishi
2024-11-09 10:33   ` [PATCH v3 03/10] dt-bindings: display: bridge: lvds-codec: add doestek,dtc34lm85am Krzysztof Kozlowski
2024-11-08 20:04 ` [PATCH v3 04/10] dt-bindings: display: panel-lvds: Add compatible for Samsung LTN070NL01 Panel Mithil Bavishi
2024-11-09 10:33   ` Krzysztof Kozlowski
2024-11-08 20:04 ` [PATCH v3 05/10] dt-bindings: display: panel-lvds: Add compatible for Samsung LTN101AL03 Panel Mithil Bavishi
2024-11-09 10:34   ` Krzysztof Kozlowski
2024-11-08 20:04 ` [PATCH v3 06/10] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series Mithil Bavishi
2024-11-12  9:06   ` Andreas Kemnade
2024-11-23 18:14     ` Mithil Bavishi
2024-11-25 21:29       ` Andreas Kemnade
2024-11-08 20:04 ` [PATCH v3 07/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 7.0 Mithil Bavishi
2024-11-09 10:34   ` Krzysztof Kozlowski
2024-11-08 20:04 ` [PATCH v3 08/10] ARM: dts: ti: omap: samsung-espresso7: Add initial support for " Mithil Bavishi
2024-11-12 11:00   ` Andreas Kemnade
2024-11-23 17:44     ` Mithil Bavishi
2024-11-08 20:04 ` [PATCH v3 09/10] dt-bindings: omap: Add Samsung Galaxy Tab 2 10.1 Mithil Bavishi
2024-11-09 10:35   ` Krzysztof Kozlowski
2024-11-08 20:04 ` [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for " Mithil Bavishi
2024-11-12 10:48   ` Andreas Kemnade
2024-11-23 17:52     ` Mithil Bavishi [this message]
2024-11-23 19:02       ` Andreas Kemnade
2024-11-23 19:26         ` Mithil Bavishi
2024-11-23 21:31           ` Andreas Kemnade
2024-11-24  7:44             ` Mithil Bavishi
2024-11-11 15:32 ` [PATCH v3 00/10] Initial support for Samsung Galaxy Tab 2 series Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241123175259.775-1-bavishimithil@gmail.com \
    --to=bavishimithil@gmail.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=airlied@gmail.com \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.