From: Jakub Kicinski <kuba@kernel.org>
To: Samiullah Khawaja <skhawaja@google.com>,
Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
Willem de Bruijn <willemb@google.com>,
Kaiyuan Zhang <kaiyuanz@google.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: Re: [PATCH net-next v2 4/5] page_pool: disable sync for cpu for dmabuf memory provider
Date: Sat, 23 Nov 2024 18:33:51 -0800 [thread overview]
Message-ID: <20241123183351.582aa8ac@kernel.org> (raw)
In-Reply-To: <CAAywjhRb0Lb9fJocWBU1r01521sy71hLOaH=92gqceXqUOGHJg@mail.gmail.com>
On Fri, 22 Nov 2024 14:10:28 -0800 Samiullah Khawaja wrote:
> > > > If you do this you may want to block accepting dmabufs that have CPU
> > > > pages inside them.
>
> I believe we should be following the dmabuf API for this purpose, if
> we really want to sync for CPU in. page_pool, and should not assume
> the behaviour of the backing memory.
>
> The dmabuf exporters are supposed to implement the begin_cpu_access
> (optional) and the sync for cpu is done based on the exporter
> implementation.
DMABUF is a bit of a distraction here.
What's key is that we need to fill in the gap in the driver facing
page_pool API, because DMABUF will not be the only provider we can
plug in.
next prev parent reply other threads:[~2024-11-24 2:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 21:23 [PATCH net-next v2 0/5] devmem TCP fixes Mina Almasry
2024-11-07 21:23 ` [PATCH net-next v2 1/5] net: page_pool: rename page_pool_alloc_netmem to *_netmems Mina Almasry
2024-11-08 15:53 ` Stanislav Fomichev
2024-11-07 21:23 ` [PATCH net-next v2 2/5] net: page_pool: create page_pool_alloc_netmem Mina Almasry
2024-11-08 15:53 ` Stanislav Fomichev
2024-11-07 21:23 ` [PATCH net-next v2 3/5] page_pool: Set `dma_sync` to false for devmem memory provider Mina Almasry
2024-11-08 15:53 ` Stanislav Fomichev
2024-11-08 16:34 ` Pavel Begunkov
2024-11-12 2:34 ` Jakub Kicinski
2024-11-07 21:23 ` [PATCH net-next v2 4/5] page_pool: disable sync for cpu for dmabuf " Mina Almasry
2024-11-08 14:18 ` Jason Gunthorpe
2024-11-08 15:58 ` Stanislav Fomichev
2024-11-08 16:39 ` Pavel Begunkov
2024-11-08 19:01 ` Mina Almasry
2024-11-15 1:59 ` Jason Gunthorpe
2024-11-22 22:10 ` Samiullah Khawaja
2024-11-24 2:33 ` Jakub Kicinski [this message]
2024-11-07 21:23 ` [PATCH net-next v2 5/5] netmem: add netmem_prefetch Mina Almasry
2024-11-08 2:56 ` kernel test robot
2024-11-08 3:29 ` kernel test robot
2024-11-08 4:21 ` kernel test robot
2024-11-08 15:55 ` Stanislav Fomichev
2024-11-12 2:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241123183351.582aa8ac@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kaiyuanz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhawaja@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.