All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	nic_swsd@realtek.com, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 6.12 030/107] r8169: don't apply UDP padding quirk on RTL8126A
Date: Sun, 24 Nov 2024 08:28:50 -0500	[thread overview]
Message-ID: <20241124133301.3341829-30-sashal@kernel.org> (raw)
In-Reply-To: <20241124133301.3341829-1-sashal@kernel.org>

From: Heiner Kallweit <hkallweit1@gmail.com>

[ Upstream commit 87e26448dbda4523b73a894d96f0f788506d3795 ]

Vendor drivers r8125/r8126 indicate that this quirk isn't needed
any longer for RTL8126A. Mimic this in r8169.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/d1317187-aa81-4a69-b831-678436e4de62@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/ethernet/realtek/r8169_main.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 713a89bb21e93..5ed2818bac257 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4233,8 +4233,8 @@ static unsigned int rtl8125_quirk_udp_padto(struct rtl8169_private *tp,
 {
 	unsigned int padto = 0, len = skb->len;
 
-	if (rtl_is_8125(tp) && len < 128 + RTL_MIN_PATCH_LEN &&
-	    rtl_skb_is_udp(skb) && skb_transport_header_was_set(skb)) {
+	if (len < 128 + RTL_MIN_PATCH_LEN && rtl_skb_is_udp(skb) &&
+	    skb_transport_header_was_set(skb)) {
 		unsigned int trans_data_len = skb_tail_pointer(skb) -
 					      skb_transport_header(skb);
 
@@ -4258,9 +4258,15 @@ static unsigned int rtl8125_quirk_udp_padto(struct rtl8169_private *tp,
 static unsigned int rtl_quirk_packet_padto(struct rtl8169_private *tp,
 					   struct sk_buff *skb)
 {
-	unsigned int padto;
+	unsigned int padto = 0;
 
-	padto = rtl8125_quirk_udp_padto(tp, skb);
+	switch (tp->mac_version) {
+	case RTL_GIGA_MAC_VER_61 ... RTL_GIGA_MAC_VER_63:
+		padto = rtl8125_quirk_udp_padto(tp, skb);
+		break;
+	default:
+		break;
+	}
 
 	switch (tp->mac_version) {
 	case RTL_GIGA_MAC_VER_34:
-- 
2.43.0


  parent reply	other threads:[~2024-11-24 13:34 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24 13:28 [PATCH AUTOSEL 6.12 001/107] drm/xe/pciids: separate RPL-U and RPL-P PCI IDs Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 002/107] drm/xe/pciids: separate ARL and MTL " Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 003/107] drm/vc4: hdmi: Avoid log spam for audio start failure Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 004/107] drm/vc4: hvs: Set AXI panic modes for the HVS Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 005/107] drm/vc4: hdmi: Increase audio MAI fifo dreq threshold Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 006/107] drm/xe/pciids: Add PVC's PCI device ID macros Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 007/107] wifi: rtw88: use ieee80211_purge_tx_queue() to purge TX skb Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 008/107] drm/xe/pciid: Add new PCI id for ARL Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 009/107] udmabuf: change folios array from kmalloc to kvmalloc Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 010/107] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 011/107] drm: panel-orientation-quirks: Add quirk for AYA NEO Founder edition Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 012/107] drm: panel-orientation-quirks: Add quirk for AYA NEO GEEK Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 013/107] drm/bridge: it6505: Enable module autoloading Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 014/107] drm/mcde: " Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 015/107] wifi: rtw89: check return value of ieee80211_probereq_get() for RNR Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 016/107] drm/amd/display: Block UHBR Based On USB-C PD Cable ID Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 017/107] drm/amd/display: Fix out-of-bounds access in 'dcn21_link_encoder_create' Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 018/107] drm/radeon/r600_cs: Fix possible int overflow in r600_packet3_check() Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 019/107] ASoC: Intel: sof_rt5682: Add HDMI-In capture with rt5682 support for MTL Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 020/107] dlm: fix possible lkb_resource null dereference Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 021/107] drm/amd/display: skip disable CRTC in seemless bootup case Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 022/107] drm/amd/display: Fix garbage or black screen when resetting otg Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 023/107] drm/amd/display: disable SG displays on cyan skillfish Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 024/107] drm/xe/ptl: L3bank mask is not available on the media GT Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 025/107] drm/xe/xe3: Add initial set of workarounds Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 026/107] drm/display: Fix building with GCC 15 Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 027/107] ALSA: hda: Use own quirk lookup helper Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 028/107] ALSA: hda/conexant: Use the new codec SSID matching Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 029/107] ALSA: hda/realtek: Use codec SSID matching for Lenovo devices Sasha Levin
2024-11-24 13:28 ` Sasha Levin [this message]
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 031/107] samples/bpf: Fix a resource leak Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 032/107] wifi: ath12k: fix atomic calls in ath12k_mac_op_set_bitrate_mask() Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 033/107] accel/qaic: Add AIC080 support Sasha Levin
2024-11-24 19:07   ` Jeffrey Hugo
2024-12-10 16:16     ` Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 034/107] drm/amd/display: Full exit out of IPS2 when all allow signals have been cleared Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 035/107] net: fec_mpc52xx_phy: Use %pa to format resource_size_t Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 036/107] net: ethernet: fs_enet: " Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 037/107] net/sched: cbs: Fix integer overflow in cbs_set_port_rate() Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 038/107] af_packet: avoid erroring out after sock_init_data() in packet_create() Sasha Levin
2024-11-24 13:28 ` [PATCH AUTOSEL 6.12 039/107] Bluetooth: L2CAP: do not leave dangling sk pointer on error in l2cap_sock_create() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 040/107] Bluetooth: RFCOMM: avoid leaving dangling sk pointer in rfcomm_sock_alloc() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 041/107] net: af_can: do not leave a dangling sk pointer in can_create() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 042/107] net: ieee802154: do not leave a dangling sk pointer in ieee802154_create() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 043/107] net: inet: do not leave a dangling sk pointer in inet_create() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 044/107] net: inet6: do not leave a dangling sk pointer in inet6_create() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 045/107] wifi: ath10k: avoid NULL pointer error during sdio remove Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 046/107] wifi: ath5k: add PCI ID for SX76X Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 047/107] wifi: ath5k: add PCI ID for Arcadyan devices Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 048/107] fanotify: allow reporting errors on failure to open fd Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 049/107] bpf: Prevent tailcall infinite loop caused by freplace Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 050/107] ASoC: sdw_utils: Add support for exclusion DAI quirks Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 051/107] ASoC: sdw_utils: Add a quirk to allow the cs42l43 mic DAI to be ignored Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 052/107] ASoC: Intel: sof_sdw: Add quirk for cs42l43 system using host DMICs Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 053/107] ASoC: Intel: sof_sdw: Add quirks for some new Lenovo laptops Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 054/107] drm/xe/guc/ct: Flush g2h worker in case of g2h response timeout Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 055/107] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 056/107] net: sfp: change quirks for Alcatel Lucent G-010S-P Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 057/107] net: stmmac: Programming sequence for VLAN packets with split header Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 058/107] drm/sched: memset() 'job' in drm_sched_job_init() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 059/107] drm/amd/display: Adding array index check to prevent memory corruption Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 060/107] drm/amdgpu/gfx9: Add cleaner shader for GFX9.4.2 Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 061/107] drm/amdgpu: clear RB_OVERFLOW bit when enabling interrupts for vega20_ih Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 062/107] drm/amdgpu: Dereference the ATCS ACPI buffer Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 063/107] netlink: specs: Add missing bitset attrs to ethtool spec Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 064/107] drm/amdgpu: refine error handling in amdgpu_ttm_tt_pin_userptr Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 065/107] ASoC: sdw_utils: Add quirk to exclude amplifier function Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 066/107] ASoC: Intel: soc-acpi-intel-arl-match: Add rt722 and rt1320 support Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 067/107] drm/amd/display: Fix underflow when playing 8K video in full screen mode Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 068/107] mptcp: annotate data-races around subflow->fully_established Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 069/107] dma-debug: fix a possible deadlock on radix_lock Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 070/107] jfs: array-index-out-of-bounds fix in dtReadFirst Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 071/107] jfs: fix shift-out-of-bounds in dbSplit Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 072/107] jfs: fix array-index-out-of-bounds in jfs_readdir Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 073/107] jfs: add a check to prevent array-index-out-of-bounds in dbAdjTree Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 074/107] fsl/fman: Validate cell-index value obtained from Device Tree Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 075/107] net/tcp: Add missing lockdep annotations for TCP-AO hlist traversals Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 076/107] net: enetc: remove ERR050089 workaround for i.MX95 Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 077/107] net: enetc: add i.MX95 EMDIO support Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 078/107] drm/panic: Add ABGR2101010 support Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 079/107] Revert "drm/amd/display: Block UHBR Based On USB-C PD Cable ID" Sasha Levin
2024-11-25 11:35   ` Michel Dänzer
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 080/107] drm/amd/display: Remove hw w/a toggle if on DP2/HPO Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 081/107] drm/amd/display: parse umc_info or vram_info based on ASIC Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 082/107] drm/amd/display: Prune Invalid Modes For HDMI Output Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 083/107] drm/amdgpu: skip amdgpu_device_cache_pci_state under sriov Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 084/107] virtio-net: fix overflow inside virtnet_rq_alloc Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 085/107] ALSA: usb-audio: Make mic volume workarounds globally applicable Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 086/107] drm/amdgpu: set the right AMDGPU sg segment limitation Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 087/107] wifi: ipw2x00: libipw_rx_any(): fix bad alignment Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 088/107] wifi: brcmfmac: Fix oops due to NULL pointer dereference in brcmf_sdiod_sglist_rw() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 089/107] bpf: Call free_htab_elem() after htab_unlock_bucket() Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 090/107] mptcp: fix possible integer overflow in mptcp_reset_tout_timer Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 091/107] dsa: qca8k: Use nested lock to avoid splat Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 092/107] i2c: i801: Add support for Intel Panther Lake Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 093/107] Bluetooth: hci_conn: Reduce hci_conn_drop() calls in two functions Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 094/107] Bluetooth: btusb: Add RTL8852BE device 0489:e123 to device tables Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 095/107] Bluetooth: btusb: Add USB HW IDs for MT7920/MT7925 Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 096/107] Bluetooth: hci_conn: Use disable_delayed_work_sync Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 097/107] Bluetooth: hci_core: Fix not checking skb length on hci_acldata_packet Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 098/107] Bluetooth: Add new quirks for ATS2851 Sasha Levin
2024-11-24 13:29 ` [PATCH AUTOSEL 6.12 099/107] Bluetooth: Support " Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 100/107] Bluetooth: Set " Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 101/107] Bluetooth: btusb: Add new VID/PID 0489/e111 for MT7925 Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 102/107] Bluetooth: btusb: Add new VID/PID 0489/e124 " Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 103/107] Bluetooth: btusb: Add 3 HWIDs " Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 104/107] ASoC: hdmi-codec: reorder channel allocation list Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 105/107] rocker: fix link status detection in rocker_carrier_init() Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 106/107] net/neighbor: clear error in case strict check is not set Sasha Levin
2024-11-24 13:30 ` [PATCH AUTOSEL 6.12 107/107] netpoll: Use rcu_access_pointer() in __netpoll_setup Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241124133301.3341829-30-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.